Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapcraft.yaml #1042

Closed
wants to merge 2 commits into from
Closed

Conversation

eugeneseppel
Copy link

@eugeneseppel eugeneseppel commented Jan 21, 2022

snapcraft.yaml is updated to make possible snapcraft build on Ubuntu 20.04 LTS
In scope of this PR:

  • added the required dependency libasound2,
  • base core specified explicitly as it is needed for the current snapcraft,
  • service (daemon) is removed from snap. I think that running this daemon under superuser account (even in a confined snap) is not a best option from the security perspective. Also different PC users may require different Spotify premium credentials (like family members with different music taste) and the best place to store the credentials is user's profile or keychain, but single spotifyd system instance can't use every user's keychain with the default configuration. So the current approach of running spotifyd as a system-wide service is insecure, non-manageable and not suitable for everyone. Hereby it's better to leave such configuration on user's responsibility than introduce the insecure approach.

@eugeneseppel
Copy link
Author

Original problem with "." source (source folder was not populated to the build VM) was because of the source folder location

@eugeneseppel
Copy link
Author

Could please someone else also approve this? 2 approvals are needed.
Thank you!

@robinvd robinvd requested a review from a team February 8, 2022 16:23
@eladyn
Copy link
Member

eladyn commented Sep 9, 2022

LGTM! Regarding the third change, I do have some questions:

service (daemon) is removed from snap. I think that running this daemon under superuser account (even in a confined snap) is not a best option from the security perspective.

This documentation suggests to me that spotifyd isn't actually run with root, so this shouldn't be a problem security-wise?

Also different PC users may require different Spotify premium credentials (like family members with different music taste) and the best place to store the credentials is user's profile or keychain, but single spotifyd system instance can't use every user's keychain with the default configuration. So the current approach of running spotifyd as a system-wide service is insecure, non-manageable and not suitable for everyone. Hereby it's better to leave such configuration on user's responsibility than introduce the insecure approach.

I'm not at all familiar with snaps, but I think I understand your reasoning here. Unfortunately, a daemon-scope: user feature, which – it seems – would fit perfectly in this situation, still hasn't made it out of the experimental phase.

Is there a way that users can execute a snap command directly, even if it is installed as a system service. The reason I'm asking is that I would suspect that most people using the snap rely on it being available as a system daemon, so changing that would break their setup, right?

@slondr slondr added the waiting for feedback Issues that need user feedback for e.g. log files label Mar 9, 2023
@slondr
Copy link
Member

slondr commented Mar 11, 2023

Closed as we no longer officially support snap

@slondr slondr closed this Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Issues that need user feedback for e.g. log files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants