Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on playerctl command #258

Closed
samuelallan72 opened this issue Jun 24, 2019 · 11 comments
Closed

Crash on playerctl command #258

samuelallan72 opened this issue Jun 24, 2019 · 11 comments
Labels
blocked by: rspotify bug A functionality or parts of a program that do not work as intended help wanted Issues that need help since the assigned person has little to no knowledge about the topic
Projects
Fix dbus_mpris implementation
Milestone
v0.2.18

Comments

@samuelallan72
Copy link

When running a command from playerctl (over dbus), spotifyd crashes with

[ERROR] 11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
Caught panic with message: called `Result::unwrap()` on an `Err` value: Error(Executor(EnterError { reason: "attempted to run an executor while another executor is already running" }), "https://api.spotify.com/v1/me/player")

This is git master at the time of writing with all features enabled.

More debug log for context:

...
11:47:05 [DEBUG] tokio_core::reactor: loop poll - 1.597µs
11:47:05 [DEBUG] tokio_core::reactor: loop time - Instant { tv_sec: 2643, tv_nsec: 516027470 }
11:47:05 [DEBUG] tokio_core::reactor: loop process, 8.665µs
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [DEBUG] dbus_tokio::adriver: D-Bus i/o poll ready: 29 is Ready(Readable)
11:47:07 [DEBUG] dbus_tokio::adriver: D-Bus i/o unix ready: 29 is Readable | Aio
11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
11:47:07 [DEBUG] dbus_tokio::adriver: handle_msgs: (MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll"))
11:47:07 [DEBUG] tokio_core::reactor: loop poll - 1.603341812s
11:47:07 [DEBUG] tokio_core::reactor: loop time - Instant { tv_sec: 2645, tv_nsec: 119382030 }
11:47:07 [DEBUG] tokio_core::reactor: loop process, 9.295µs
11:47:07 [DEBUG] dbus_tokio::adriver: Polling message stream
11:47:07 [DEBUG] dbus_tokio::adriver: msgstream found Ok(Ready(Some((MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll")))))
11:47:07 [TRACE] mio::poll: [<unknown>:787] registering with poller
11:47:07 11:47:07 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(4194303)
[ERROR] 11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
Caught panic with message: called `Result::unwrap()` on an `Err` value: Error(Executor(EnterError { reason: "attempted to run an executor while another executor is already running" }), "https://api.spotify.com/v1/me/player")
11:47:07 [TRACE] reqwest::client: [<unknown>:578] response receiver is canceled
11:47:07 [TRACE] tokio_reactor: [<unknown>:390] loop process - 0 events, 0.000s
11:47:07 [DEBUG] librespot_connect::spirc: drop Spirc[0]
11:47:07 [DEBUG] librespot_playback::player: Shutting down player thread ...
11:47:07 [DEBUG] librespot_playback::player: drop Player[0]
11:47:07 [DEBUG] librespot_core::session: drop Session[0]
11:47:07 [DEBUG] librespot::component: drop AudioKeyManager
11:47:07 [DEBUG] librespot::component: drop ChannelManager
11:47:07 [DEBUG] librespot::component: drop MercuryManager
11:47:07 [DEBUG] dbus_tokio::adriver: Dropping AMessageStream
11:47:07 [DEBUG] dbus_tokio::adriver: AMessageStream telling ADriver to quit
11:47:07 [TRACE] tokio_threadpool::pool: [<unknown>:138] shutdown; state=pool::State { lifecycle: Running, num_futures: 0 }
11:47:07 [TRACE] tokio_threadpool::pool: [<unknown>:186]   -> transitioned to shutdown
11:47:07 [TRACE] tokio_threadpool::pool: [<unknown>:207]   -> shutting down workers
11:47:07 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
11:47:07 [DEBUG] tokio_reactor: dropping I/O source: 0
11:47:07 [DEBUG] tokio_reactor: dropping I/O source: 3
11:47:07 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
11:47:07 [DEBUG] tokio_reactor: dropping I/O source: 1
11:47:07 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
11:47:07 [DEBUG] tokio_reactor: dropping I/O source: 2
11:47:07 [DEBUG] librespot_core::session: drop Dispatch
11:47:07 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
11:47:07 [DEBUG] tokio_reactor: dropping I/O source: 5
11:47:07 [DEBUG] tokio_reactor: dropping I/O source: 4
@mmikalsen
Copy link

mmikalsen commented Jun 24, 2019 •
edited
Loading

gets the same error:

15:58:36 [DEBUG] dbus_tokio::adriver: D-Bus i/o poll ready: 23 is Ready(Readable)
15:58:36 [DEBUG] dbus_tokio::adriver: D-Bus i/o unix ready: 23 is Readable | Aio
15:58:36 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(25165828)
15:58:36 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
15:58:36 [DEBUG] dbus_tokio::adriver: handle_msgs: (MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll"))
15:58:36 [DEBUG] dbus_tokio::adriver: handle_msgs: (MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll"))
15:58:36 [DEBUG] tokio_core::reactor: loop poll - 12.325823ms
15:58:36 [DEBUG] tokio_core::reactor: loop time - Instant { tv_sec: 3372, tv_nsec: 849950738 }
15:58:36 [DEBUG] tokio_core::reactor: loop process, 9.885µs
15:58:36 [DEBUG] dbus_tokio::adriver: D-Bus i/o poll ready: 23 is Ready(Readable)
15:58:36 [DEBUG] dbus_tokio::adriver: D-Bus i/o unix ready: 23 is Readable | Aio
15:58:36 [DEBUG] tokio_reactor::registration: scheduling Read for: 4
15:58:36 [DEBUG] tokio_core::reactor: loop poll - 18.502µs
15:58:36 [DEBUG] tokio_core::reactor: loop time - Instant { tv_sec: 3372, tv_nsec: 849985057 }
15:58:36 [DEBUG] tokio_core::reactor: loop process, 7.767µs
^C15:58:38 [TRACE] tokio_reactor: [<unknown>:376] event Readable | Writable Token(12582915)
15:58:38 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
15:58:38 [DEBUG] tokio_reactor::registration: scheduling Read for: 3
15:58:38 [DEBUG] tokio_core::reactor: loop poll - 1.43861386s
15:58:38 [DEBUG] tokio_core::reactor: loop time - Instant { tv_sec: 3374, tv_nsec: 288610511 }
15:58:38 [DEBUG] tokio_core::reactor: loop process, 24.154µs
15:58:38 [DEBUG] dbus_tokio::adriver: Polling message stream
15:58:38 [DEBUG] dbus_tokio::adriver: msgstream found Ok(Ready(Some((Signal, Some("/org/freedesktop/DBus"), Some("org.freedesktop.DBus"), Some("NameAcquired")))))
15:58:38 [WARN] Unhandled dbus message: (Signal, Some("/org/freedesktop/DBus"), Some("org.freedesktop.DBus"), Some("NameAcquired"))
15:58:38 [DEBUG] dbus_tokio::adriver: Polling message stream
15:58:38 [DEBUG] dbus_tokio::adriver: msgstream found Ok(Ready(Some((Signal, Some("/org/freedesktop/DBus"), Some("org.freedesktop.DBus"), Some("NameAcquired")))))
15:58:38 [WARN] Unhandled dbus message: (Signal, Some("/org/freedesktop/DBus"), Some("org.freedesktop.DBus"), Some("NameAcquired"))
15:58:38 [DEBUG] dbus_tokio::adriver: Polling message stream
15:58:38 [DEBUG] dbus_tokio::adriver: msgstream found Ok(Ready(Some((MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("Get")))))
15:58:38 [DEBUG] dbus_tokio::adriver: Polling message stream
15:58:38 [DEBUG] dbus_tokio::adriver: msgstream found Ok(Ready(Some((MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll")))))
15:58:38 [DEBUG] dbus_tokio::adriver: Polling message stream
15:58:38 [DEBUG] dbus_tokio::adriver: msgstream found Ok(Ready(Some((MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll")))))
15:58:38 [TRACE] mio::poll: [<unknown>:787] registering with poller
15:58:38 [ERROR] Caught panic with message: 15:58:38 [TRACE] tokio_reactor: [<unknown>:376] event Readable Token(4194303)
called `Result::unwrap()` on an `Err` value: Error(Executor(EnterError { reason: "attempted to run an executor while another executor is already running" }), "https://api.spotify.com/v1/me/player")
15:58:38 [TRACE] tokio_reactor: [<unknown>:390] loop process - 1 events, 0.000s
15:58:38 [DEBUG] librespot_connect::spirc: drop Spirc[0]
15:58:38 [DEBUG] librespot_playback::player: Shutting down player thread ...
15:58:38 [TRACE] reqwest::client: [<unknown>:578] response receiver is canceled
15:58:38 [DEBUG] librespot_playback::player: drop Player[0]
15:58:38 [TRACE] tokio_reactor: [<unknown>:390] loop process - 0 events, 0.000s
15:58:38 [DEBUG] librespot_core::session: drop Session[0]
15:58:38 [DEBUG] librespot::component: drop MercuryManager
15:58:38 [DEBUG] dbus_tokio::adriver: Dropping AMessageStream
15:58:38 [DEBUG] dbus_tokio::adriver: AMessageStream telling ADriver to quit
15:58:38 [TRACE] tokio_threadpool::pool: [<unknown>:138] shutdown; state=pool::State { lifecycle: Running, num_futures: 0 }
15:58:38 [TRACE] tokio_threadpool::pool: [<unknown>:186]   -> transitioned to shutdown
15:58:38 [TRACE] tokio_threadpool::pool: [<unknown>:207]   -> shutting down workers
15:58:38 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
15:58:38 [DEBUG] tokio_reactor: dropping I/O source: 0
15:58:38 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
15:58:38 [DEBUG] tokio_reactor: dropping I/O source: 1
15:58:38 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
15:58:38 [DEBUG] tokio_reactor: dropping I/O source: 2
15:58:38 [DEBUG] librespot_core::session: drop Dispatch
15:58:38 [TRACE] mio::poll: [<unknown>:907] deregistering handle with poller
15:58:38 [DEBUG] tokio_reactor: dropping I/O source: 5
15:58:38 [DEBUG] tokio_reactor: dropping I/O source: 4
15:58:38 [DEBUG] tokio_reactor: dropping I/O source: 3

@taigrr
Copy link

taigrr commented Jun 24, 2019 •
edited
Loading

Bump. This started happening for me now after the latest version.

For now, I've rolled back:
spotifyd-full-0.2.10-1-x86_64.pkg.tar.xz
works fine for me.

@TimOverboard TimOverboard mentioned this issue Jul 10, 2019
Closed
@mainrs mainrs added the bug A functionality or parts of a program that do not work as intended label Sep 5, 2019
@mainrs mainrs added this to To do in Fix dbus_mpris implementation via automation Sep 5, 2019
@mainrs mainrs added the help wanted Issues that need help since the assigned person has little to no knowledge about the topic label Sep 5, 2019
@taigrr
Copy link

taigrr commented Sep 30, 2019

This still happens whenever I upgrade to latest. I have to fall back to the above version for things to work properly.

@taigrr taigrr mentioned this issue Sep 30, 2019
Closed
@mainrs
Copy link
Member

mainrs commented Sep 30, 2019

@taigrr Does this happen with any command you send or only some specifics? Super hard to tackle this one down to be honest :(

@taigrr
Copy link

taigrr commented Sep 30, 2019 •
edited
Loading

@sirwindfield Give me a moment, I'll update this comment with some log files. Currently switching back to latest from 0.2.10...

Alright here you go:

21:13:15 [WARN] error sending packet Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }
21:13:15 [INFO] Connecting to AP "guc3-accesspoint-a-818f.ap.spotify.com:443"
21:13:16 [INFO] Authenticated as "guitarsampler" !
21:13:16 [INFO] Using alsa sink
21:13:16 [INFO] Country: "US"
21:13:16 [WARN] Unhandled dbus message: (Signal, Some("/org/freedesktop/DBus"), Some("org.freedesktop.DBus"), Some("NameAcquired"))
21:13:16 [WARN] Unhandled dbus message: (Signal, Some("/org/freedesktop/DBus"), Some("org.freedesktop.DBus"), Some("NameAcquired"))
21:13:19 [ERROR] Caught panic with message: called `Result::unwrap()` on an `Err` value: Error(BlockingClientInFutureContext, "https://api.spotify.com/v1/me/player")

Here is some more verbose output:

21:16:39 [TRACE] (2) tokio_reactor: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-reactor-0.1.9/src/lib.rs:390] loop process - 1 events, 0.000s
21:16:39 [DEBUG] (1) dbus_tokio::adriver: D-Bus i/o poll ready: 35 is Ready(Readable)
21:16:39 [DEBUG] (1) dbus_tokio::adriver: D-Bus i/o unix ready: 35 is Readable | Aio
21:16:39 [TRACE] (2) tokio_reactor: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-reactor-0.1.9/src/lib.rs:376] event Readable Token(25165828)
21:16:39 [TRACE] (2) tokio_reactor: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-reactor-0.1.9/src/lib.rs:390] loop process - 1 events, 0.000s
21:16:39 [DEBUG] (1) dbus_tokio::adriver: handle_msgs: (MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll"))
21:16:39 [DEBUG] (1) tokio_core::reactor: loop poll - 39.911013ms
21:16:39 [DEBUG] (1) tokio_core::reactor: loop time - Instant { tv_sec: 415470, tv_nsec: 61130782 }
21:16:39 [DEBUG] (1) tokio_core::reactor: loop process, 58.967µs
21:16:39 [DEBUG] (1) dbus_tokio::adriver: Polling message stream
21:16:39 [DEBUG] (1) dbus_tokio::adriver: msgstream found Ok(Ready(Some((MethodCall, Some("/org/mpris/MediaPlayer2"), Some("org.freedesktop.DBus.Properties"), Some("GetAll")))))
21:16:39 [TRACE] (8) mio::poll: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.6.19/src/poll.rs:787] registering with poller
21:16:39 [ERROR] Caught panic with message: called `Result::unwrap()` on an `Err` value: Error(BlockingClientInFutureContext, "https://api.spotify.com/v1/me/player")
21:16:39 [TRACE] (8) tokio_reactor: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-reactor-0.1.9/src/lib.rs:376] event Readable Token(4194303)
21:16:39 [TRACE] (8) tokio_reactor: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-reactor-0.1.9/src/lib.rs:390] loop process - 1 events, 0.000s
21:16:39 [TRACE] (8) reqwest::client: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/reqwest-0.9.20/src/client.rs:588] response receiver is canceled
21:16:39 [TRACE] (8) tokio_reactor: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-reactor-0.1.9/src/lib.rs:390] loop process - 0 events, 0.000s
21:16:39 [DEBUG] (1) librespot_connect::spirc: drop Spirc[0]
21:16:39 [DEBUG] (1) librespot_playback::player: Shutting down player thread ...
21:16:39 [DEBUG] (7) librespot_playback::player: drop Player[0]
21:16:39 [DEBUG] (1) librespot_core::session: drop Session[0]
21:16:39 [DEBUG] (1) librespot::component: drop MercuryManager
21:16:39 [DEBUG] (1) dbus_tokio::adriver: Dropping AMessageStream
21:16:39 [DEBUG] (1) dbus_tokio::adriver: AMessageStream telling ADriver to quit
21:16:39 [TRACE] (1) tokio_threadpool::pool: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-threadpool-0.1.15/src/pool/mod.rs:138] shutdown; state=pool::State { lifecycle: Running, num_futures: 0 }
21:16:39 [TRACE] (1) tokio_threadpool::pool: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-threadpool-0.1.15/src/pool/mod.rs:186]   -> transitioned to shutdown
21:16:39 [TRACE] (1) tokio_threadpool::pool: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-threadpool-0.1.15/src/pool/mod.rs:207]   -> shutting down workers
21:16:39 [TRACE] (1) mio::poll: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.6.19/src/poll.rs:907] deregistering handle with poller
21:16:39 [DEBUG] (1) tokio_reactor: dropping I/O source: 0
21:16:39 [DEBUG] (1) tokio_reactor: dropping I/O source: 3
21:16:39 [DEBUG] (1) librespot_core::session: drop Dispatch
21:16:39 [TRACE] (1) mio::poll: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.6.19/src/poll.rs:907] deregistering handle with poller
21:16:39 [DEBUG] (1) tokio_reactor: dropping I/O source: 5
21:16:39 [TRACE] (1) mio::poll: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.6.19/src/poll.rs:907] deregistering handle with poller
21:16:39 [DEBUG] (1) tokio_reactor: dropping I/O source: 1
21:16:39 [TRACE] (1) mio::poll: [/home/tai/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.6.19/src/poll.rs:907] deregistering handle with poller
21:16:39 [DEBUG] (1) tokio_reactor: dropping I/O source: 2
21:16:39 [DEBUG] (1) tokio_reactor: dropping I/O source: 4

@taigrr
Copy link

taigrr commented Sep 30, 2019

@sirwindfield It seems it crashes without calling playerctl at all now. So it's hard to test and see what it was, as a new bug must have been introduced in the meantime. Before, playerctl metadata was crashing it, but now it crashes without running playerctl.

@taigrr
Copy link

taigrr commented Sep 30, 2019

My config file, in case it's relevant (doubtful):

1 [global]
2 username = ####
3 password = ####
4 device_name = ####
5 volume-normalisation = true
6 normalisation-pregain = 5

Version: spotifyd 0.2.17

@taigrr
Copy link

taigrr commented Sep 30, 2019 •
edited
Loading

It looks like seanmonstar/reqwest#541 may be related to this new issue.

Additionally, it's possible playerctl was a red herring all along and this is the real issue.

Some conversations about it here: https://stackoverflow.com/questions/57540455/error-blockingclientinfuturecontext-when-trying-to-make-a-request-from-within

(Sorry, I'd love to patch this myself but I don't have any Rust environment set up now. I might in a couple weeks though if it's still broken.)

@mainrs
Copy link
Member

mainrs commented Sep 30, 2019 •
edited
Loading

It’s probably the underlying library that we use to access the web api, rspotify. Taking a look at the reqwest version changes, the version got bumped right before releasing v0.2.11 (here). This might be the problem 🤔

@taigrr does #309 fix the issue? It probably doesn't, but the following will do :)
If you want to try it out, clone the repo and run cargo update -p reqwest:0.9.20 --precise 0.9.17 and compile afterwards. reqwest did some breaking chances on a patch version and rspotify does pin down to minor only. Pinning it down to 0.9.17 works and everything is queryable again.

I opened a PR (ramsayleung/rspotify#55) to pin down the version within rspotify itself. Hopefully this gets merged soon. It'll solve the whole playerctl and metadata crash issues 😑

@mainrs mainrs mentioned this issue Oct 1, 2019
Merged
@mainrs mainrs added this to the v0.2.18 milestone Oct 1, 2019
Fix dbus_mpris implementation automation moved this from To do to Done Oct 2, 2019
@taigrr
Copy link

taigrr commented Oct 3, 2019

Nice. I'll test it out now...

@taigrr
Copy link

taigrr commented Oct 3, 2019 •
edited
Loading

Awesome! Can confirm it doesn't crash on start, and playerctl metadata works as it used to after #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked by: rspotify bug A functionality or parts of a program that do not work as intended help wanted Issues that need help since the assigned person has little to no knowledge about the topic
Projects
No open projects
Fix dbus_mpris implementation
  
Done
Milestone
v0.2.18
Development

No branches or pull requests
4 participants
@mainrs @taigrr @mmikalsen @samuelallan72