fix reqwest breaking change #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of v0.9.18, the reqwest dependency behaves differently and actually crashes on usage. This commit fixes the version to the latest working one, v0.9.17.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v0.9.18, the reqwest dependency behaves differently and actually
crashes on usage. This commit fixes the version to the latest working
one, v0.9.17.
I have no idea why this is happening. I checked the commits between v0.9.17 and v0.9.18 (here) and the only one that stood out was this one. The commit message and the error I got in #54 sound feasible together.
The library is used within Spotifyd. We had a lot of issues opened whose source ultimately was
rspotify. I could fix the errors we got by pinning down the version of reqwest in ourCargo.lockfile to v0.9.17.To prevent other people from stumbling across this problem, I opened this PR to pin the version down to v0.9.17 for now.
The error message I received got discussed here: seanmonstar/reqwest#541. This comment draws attention to the problem that the patch version got updated with a breaking change. The issue creation date is 4 days after v0.9.18 released, so the comment is referring to that version tag.
There might be some larger refactoring needed for the long run.
reqwestdid huge changes to thee code on the master branch and even noted in the readme that the next release WILL break.Closes #54.