Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on FreeBSD #796

Merged
merged 1 commit into from Feb 8, 2021
Merged

Fix build on FreeBSD #796

merged 1 commit into from Feb 8, 2021

Conversation

MikaelUrankar
Copy link
Contributor

Fix:

error[E0425]: cannot find value `get_shell_ffi` in this scope                                                                                                              
  --> src/utils.rs:71:48                                                                                                                                                   
   |                                                                                                                                                                       
71 |     let shell = env::var("SHELL").ok().or_else(get_shell_ffi);                                                                                                        
   |                                                ^^^^^^^^^^^^^ not found in this scope

robinvd
robinvd approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@robinvd robinvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cant test on freebsd but it looks fine!

@xanderio
Copy link

xanderio commented Feb 6, 2021

I can confirm that this change works on FreeBSD

@robinvd robinvd requested review from JojiiOfficial and a team February 8, 2021 10:47
@robinvd
Copy link
Contributor

robinvd commented Feb 8, 2021

Thx @xanderio always helpful to have a second opinion! now we just need one more maintainer to approve, i have requested a review

@robinvd robinvd self-assigned this Feb 8, 2021
@JojiiOfficial JojiiOfficial merged commit 1032694 into Spotifyd:master Feb 8, 2021
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Feb 22, 2021
@atomicules
Update spotifyd to 0.3.0
124e53a 
Important, you'll like hit this [upstream issue][1] and see something
like:

```
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:
Error { inner: ErrorInner { kind: Custom, line: Some(64), col: 17, at:
Some(1937), message: "invalid type: integer `90`, expected a string",
key: ["global", "initial_volume"] } }', src/config.rs:468:67
note: run with `RUST_BACKTRACE=1` environment variable to display a
backtrace
```

This is due to the config format changing and values needing quoting.

Adds a new patch [based on this PR][2].

[1]: Spotifyd/spotifyd#765
[2]: Spotifyd/spotifyd#796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JojiiOfficial JojiiOfficial JojiiOfficial approved these changes

@robinvd robinvd robinvd approved these changes

Assignees

@robinvd robinvd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikaelUrankar @xanderio @robinvd @JojiiOfficial