Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Config structs according to features #800

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Refactor Config structs according to features #800

wants to merge 7 commits into from

Commits on Jan 31, 2021

  1. Refactor Config structs according to features 

    As it was stated in Spotifyd#349, structs like `SharedConfigValues` or
`SpotifydConfig` contain fields like `mixer`, `control` and `device`
which only apply if `alsa-backend` feature is enabled.

Therefore, it would be nice if these fields were only documented when
the feature is enabled as well as used.

Closes Spotifyd#349
    @CPerezz
    CPerezz committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    5ddc361 View commit details
    Browse the repository at this point in the history

  2. Update Cargo.lock

    @CPerezz
    CPerezz committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    bd2c13f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Refactor merge! macro cfg code

    @CPerezz
    CPerezz committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    8835bb0 View commit details
    Browse the repository at this point in the history

  2. Add tests for merge! macro adaptation

    @CPerezz
    CPerezz committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    a827faf View commit details
    Browse the repository at this point in the history

  3. Bring back Option<String> for Playback types

    @CPerezz
    CPerezz committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    58d55a5 View commit details
    Browse the repository at this point in the history

  4. Add suggestions to remove alsa-dependand configs 

    In the wiki mdbook it's not stated clearly that the config
options that refer to `mixer`, `controller` and `device` can
be directly commented out since they're only used when
spotifyd is compiled with `alsa_backend` feature.
    @CPerezz
    CPerezz committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    f14aea3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Conditionally create AudioSetup depending on alsa

    @CPerezz
    CPerezz committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b2d5d80 View commit details
    Browse the repository at this point in the history