Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update systemd documentation and systemd examples #894

Merged
merged 5 commits into from Sep 30, 2022

Conversation

tomodachi
Copy link
Contributor

Hi people

It's not clear from the systemd example exactly how a user systemd service works.

With the given example spotifyd will only be started when the user logs in to the system
and it will also be stopped as soon as the user logs out.

That might not be a expected behaviour for a setup like a small headless device always connected to your speakers.
So I've added an example for that and made some clarifications.

…logged in. Add example for an always running systemd service
Copy link
Contributor

@robinvd robinvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! more/better docs are always welcome.

docs/src/config/services/Systemd.md Outdated Show resolved Hide resolved
@robinvd robinvd self-assigned this Mar 3, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Jun 2, 2021
@robinvd robinvd added the pinned Apply to make stale bot ignore issue/PR. label Jun 11, 2021
@stale stale bot removed the wontfix Issues that will not be fixed under any circumstances label Jun 11, 2021
Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, if you are still interested in this @tomodachi, but if you are (which would be great), I have some small suggestions. Other than that, LGTM.

docs/src/config/services/Systemd.md Show resolved Hide resolved
docs/src/config/services/Systemd.md Outdated Show resolved Hide resolved
docs/src/config/services/Systemd.md Outdated Show resolved Hide resolved
slondr and others added 3 commits September 10, 2022 22:44
Co-authored-by: eladyn <59307989+eladyn@users.noreply.github.com>
Co-authored-by: eladyn <59307989+eladyn@users.noreply.github.com>
Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eladyn eladyn requested a review from robinvd September 11, 2022 12:10
Copy link
Member

@slondr slondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@slondr
Copy link
Member

slondr commented Sep 29, 2022

@robinvd this look good to you?

@eladyn eladyn merged commit 99c20d0 into Spotifyd:master Sep 30, 2022
Icelk pushed a commit to Icelk/spotifyd that referenced this pull request Nov 17, 2022
Clarify that a systemd user service actually only works when user is logged in. Add example for an always running systemd service

Co-authored-by: Eric S. Londres <ericlondres@outlook.com>
Co-authored-by: eladyn <59307989+eladyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Apply to make stale bot ignore issue/PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants