fix: (no)gil/except declarations on MIDI in callback and sendMessage #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GIL is acquired in any case for MIDI in callback and `sendMessage`, since Cython needs to check C++ call for exceptions Also remove wrong statement about the GIL being released in docstring for `sendMessage` Lastly, suppress related Cython performance hints Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
SpotlightKid
force-pushed
the
fix/callbacks-gil
branch
from
b16d7c9
to
4fa4958
Compare
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 7, 2023
https://build.opensuse.org/request/show/1123698 by user mia + anag+factory - Omit html docs due to hostile build system - Update to 1.5.7 Fixes: * Fixed linting errors in `send_all.py` example. gh#SpotlightKid/python-rtmidi#184 * Fixed (no)gil/except declarations on MIDI in callback and `MidiOut.sendMessage`. The GIL is acquired in any case for MIDI in callback and C++ `sendMessage` call, since Cython needs to check for exceptions. Also remove wrong statement about the GIL being released in docstring for `send_message`. gh#SpotlightKid/python-rtmidi#185 * Fixed errors and check for empty message correctly when passing an iter- or generator instead of a sequence to `MidiOut.send_message`. gh#SpotlightKid/python-rtmidi#186 gh#SpotlightKid/python-rtmidi#188 - 1.5.6 Fixes: * Fixed building with `meson-python` >= 0.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIL is acquired in any case for MIDI in callback and
sendMessage, since Cython needs to check C++ call for exceptionsAlso remove wrong statement about the GIL being released in docstring for
sendMessageLastly, suppress related Cython performance hints