Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): [security] bump json from 2.1.0 to 2.5.1 #231

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

build(deps): [security] bump json from 2.1.0 to 2.5.1 #231

wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps json from 2.1.0 to 2.5.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

json Gem for Ruby Unsafe Object Creation Vulnerability (additional fix) There is an unsafe object creation vulnerability in the json gem bundled with Ruby. This vulnerability has been assigned the CVE identifier CVE-2020-10663. We strongly recommend upgrading the json gem.

Details

When parsing certain JSON documents, the json gem (including the one bundled with Ruby) can be coerced into creating arbitrary objects in the target system.

This is the same issue as CVE-2013-0269. The previous fix was incomplete, which addressed JSON.parse(user_input), but didn’t address some other styles of JSON parsing including JSON(user_input) and JSON.parse(user_input, nil).

See CVE-2013-0269 in detail. Note that the issue was exploitable to cause a Denial of Service by creating many garbage-uncollectable Symbol objects, but this kind of attack is no longer valid because Symbol objects are now garbage-collectable. However, creating arbitrary objects may cause severe security consequences depending upon the application code.

Patched versions: >= 2.3.0 Unaffected versions: none

Changelog

Sourced from json's changelog.

2020-12-22 (2.5.1)

  • Restore the compatibility for constants of JSON class.

2020-12-22 (2.5.0)

  • Ready to Ractor-safe at Ruby 3.0.

2020-12-17 (2.4.1)

  • Restore version.rb with 2.4.1

2020-12-15 (2.4.0)

  • Implement a freeze: parser option #447
  • Fix an issue with generate_pretty and empty objects in the Ruby and Java implementations #449
  • Fix JSON.load_file doc #448
  • Fix pure parser with unclosed arrays / objects #425
  • bundle the LICENSE file in the gem #444
  • Add an option to escape forward slash character #405
  • RDoc for JSON #439 #446 #442 #434 #433 #430

2020-06-30 (2.3.1)

  • Spelling and grammar fixes for comments. Pull request #191 by Josh Kline.
  • Enhance generic JSON and #generate docs. Pull request #347 by Victor Shepelev.
  • Add :nodoc: for GeneratorMethods. Pull request #349 by Victor Shepelev.
  • Baseline changes to help (JRuby) development. Pull request #371 by Karol Bucek.
  • Add metadata for rubygems.org. Pull request #379 by Alexandre ZANNI.
  • Remove invalid JSON.generate description from JSON module rdoc. Pull request #384 by Jeremy Evans.
  • Test with TruffleRuby in CI. Pull request #402 by Benoit Daloze.
  • Rdoc enhancements. Pull request #413 by Burdette Lamar.
  • Fixtures/ are not being tested... Pull request #416 by Marc-André Lafortune.
  • Use frozen string for hash key. Pull request #420 by Marc-André Lafortune.
  • Added :call-seq: to RDoc for some methods. Pull request #422 by Burdette Lamar.
  • Small typo fix. Pull request #423 by Marc-André Lafortune.

2019-12-11 (2.3.0)

  • Fix default of create_additions to always be false for JSON(user_input) and JSON.parse(user_input, nil). Note that JSON.load remains with default true and is meant for internal serialization of trusted data. [CVE-2020-10663]
  • Fix passing args all #to_json in json/add/*.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
build(deps): [security] bump json from 2.1.0 to 2.5.1
b18710a 
Bumps [json](https://github.com/flori/json) from 2.1.0 to 2.5.1. **This update includes a security fix.**
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](flori/json@v2.1.0...v2.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Dependencies need updating security This is very important and could compromise security labels Dec 24, 2020
@dependabot-preview dependabot-preview bot mentioned this pull request Dec 24, 2020
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 749

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.667%
Totals Coverage Status
Change from base Build 412: 0.0%
Covered Lines: 13
Relevant Lines: 15
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Dependencies need updating security This is very important and could compromise security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@coveralls