Complete recode and redesign #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least IntelliJ starts using spigot 1.8 for JavaDocs causing it to not know of the existance of some methods
* New Updater * Reintroduce bStats lost in v0.10.0 On SpigotMC.org it says bStats is used since v0.9.1 but on GitHub and SpigotMC this is not true. It looks like these changes have never been published on GitHub and got overwritten on newer versions by accident
This is sadly NOT tested! My laptop can't even run Minecraft so hopefully I remember testing this in a couple of days
SpraxDev
added
bug
This was
linked to
issues
May 17, 2020
Closed
Recode to dynamically read version string and to show the window in the (Windows) Taskbar with an icon.
Stairs can no longer be upside down and when sitting on slabs that are attached to the upper half of a block, you are sitting 0.5 blocks higher. Also not recognising double slabs as slab
An accidantal `/tp @e ~ ~ ~` or a commandblock running some commands should not teleport our chair
Older versions do need WorldServer instead of CraftWorld for addEntity. By updating the newer version to use WorldServer we can easier maintain the code
bStats does not work in Spigot 1.8.0 because gson seems to be missing. Wrapping it inside an try-catch won't show a long stacktrace when we don't need the full stacktrace
* Make sure Chairs without passenger get removed * Improve JavaDocs and comments * Protect a Chair's Block (BlockBreak etc.)
Using Reflections now instead of using NBT as it is very annoying to manually check the names for a couple of methods needed when modifying NBT... A bit risky, I know... But let's hope that the fields don't change between version :fingers_crossed:
I am using old classes as a reference for what features are still missing.
* Not detecting newer versions correctly * Changed permission * Fix that nasty Updater-Message that is sent to admins onJoin
* Configure Updater * Configure enabled worlds * Player needs empty hands? * Stairs or Slabs enabled?
This was
linked to
issues
Jul 9, 2020
I've generated an own page on bStats.org, so we can create custom Graphs \o/
…ANGELOG.md) (#19) * Check if version is inside CHANGELOG.md * Update CHANGELOG.md
Have been using SonarCloud.io for a while now. First time setting it up for a Java/Maven project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has already been changed/improved?
From a server owner or player perspective
config.ymlandmessages.ymllayout has (or will be) changedFrom a developer perspective (read above too. Didn't want to repeat myself)
pom.xmlEventPrioritymore oftenWhat is still missing for the first release?
Allow players to individually toggle chairs (until logout)Add anmessages.ymlAdd signs on sides of chair checkCleanup and Prepare public API for other developers(+ Documentation)Automatically convert old BetterChairs config instead of just replacing it (already creates backup first)Add AutoRotation when a player sits on a chairFix teleporting the player back to its original coordinates (and make it optional inconfig.yml)config.yml(and maybemessages.yml)