Use Maven and setup CI #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I'm done, I want to ask @BlackScarx to use (or allow the use) of an Open Source Licence as MIT.
Somewhat ensure consistancy
* Create maven.yml * Add SpigotMC Repository to pom.xml * Using Spigot 1.15.2 instead of 1.15 * Create docs/version.txt What a nightmare this was... But learne a lot xD
RUN_ID instead of RUN_NUMBER as the id is used in the url
Using TempGlobal.java and moved some classes into the api-module
They get excluded in the final jar!
* Use 1.14.4 instead of 1.14.2 Checks did not work as intended as '~' inside an env-var didn't work as intended
They get relocated to the original location to not alter the resulting jar too much
SpraxDev
added a commit
that referenced
this pull request
May 12, 2020
I did my best to not change any Classes or Packages for compatibility reasons. But they will change in future releases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading Spigot-Executables is violating the EULA and the current setup only works using IntelliJ.
I'll update the code to use Maven and after that start updating the whole plugin as it got kind of messy over time and only received compatibility updates.
I've received write-access to the original Repo and I'll create a PR on it but it is up to @BlackScarx if he wants to merge or I officially continue maintaining his plugin.
closes #3