Uparrow/downarrow in console autofills sent messages. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console maintains an index where index == 1 refers to the message being typed, and index >= 2 refers to previously sent messages. Messages are inserted at index == 2 after send (excluding adjacent duplicates). Uparrow/downarrow adjusts the index and fills the new index's corresponding value. There is no limit to the number of stored sent messages. Also replaced Console.MessageListener with Console.sendMessageActions.default /.ircStyle for reduced code duplication.
|
Force-push fixed 4 trailing whitespaces, as flagged by Travis |
gajop
requested changes
May 10, 2020
- Revert `MessageListener` changes. For future discusion/its own PR. - Console updates sentMessageIndex on TAB and sending messages. - Fixed inconsistent spacing - Fixed extraneous line due to copy-paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console maintains an index (
sentMessageIndex) where index == 1 refers to the message being typed, and index >= 2 refers to previously sent messages. Messages are inserted at index == 2 after send (excluding adjacent duplicates). Uparrow/downarrow adjusts the index and fills the new index's corresponding value. There is no limit to the number of stored sent messages.Also replaced
Console.MessageListenerwithConsole.sendMessageActions.default/.ircStylefor reduced code duplication.This addresses #250