Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hide detail module structure #178

Merged
merged 36 commits into from Jun 12, 2022
Merged

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jun 9, 2022

Issue number and link

Fixes: #177

Describe your changes

make private mod bellow

  • pipeline::field::field_name
  • pipeline::pump_model::window_operation_parameter::aggregate
  • pipeline::pump_model::window_operation_parameter::join_parameter

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@kazuk kazuk changed the title Refactor Hide detail module structure WIP: Refactor Hide detail module structure Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #178 (f76704a) into main (0bd6733) will decrease coverage by 0.16%.
The diff coverage is 82.39%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   87.61%   87.45%   -0.17%     
==========================================
  Files         203      203              
  Lines       12249    12032     -217     
==========================================
- Hits        10732    10522     -210     
+ Misses       1517     1510       -7     
Impacted Files Coverage Δ
foreign-service/src/source.rs 94.73% <ø> (ø)
...rc/source/source_input/timed_stream/file_parser.rs 0.00% <0.00%> (ø)
...vice/src/source/source_input/timed_stream/timer.rs 0.00% <0.00%> (ø)
springql-core/src/api.rs 71.87% <ø> (ø)
springql-core/src/api/error.rs 0.00% <ø> (ø)
springql-core/src/connection.rs 97.77% <ø> (ø)
springql-core/src/expression/boolean_expression.rs 100.00% <ø> (ø)
...pression/boolean_expression/comparison_function.rs 100.00% <ø> (ø)
.../expression/boolean_expression/logical_function.rs 100.00% <ø> (ø)
...xpression/boolean_expression/numerical_function.rs 100.00% <ø> (ø)
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd6733...f76704a. Read the comment docs.

@kazuk kazuk force-pushed the hide_detail_module_structure branch 2 times, most recently from 7eba501 to a90a485 Compare June 10, 2022 01:47
@laysakura laysakura mentioned this pull request Jun 10, 2022
6 tasks
@kazuk kazuk force-pushed the hide_detail_module_structure branch from 9919511 to 97a924b Compare June 10, 2022 07:28
@kazuk kazuk force-pushed the hide_detail_module_structure branch from 1047c96 to 0103f3e Compare June 10, 2022 17:36
@kazuk kazuk marked this pull request as ready for review June 12, 2022 21:46
@kazuk kazuk changed the title WIP: Refactor Hide detail module structure Refactor Hide detail module structure Jun 12, 2022
@laysakura
Copy link
Contributor

@kazuk Thank you so much! Got far less complexity in visibility.

I pushed b4b4bbb in order to make recently-modified things pub.

@laysakura
Copy link
Contributor

@kazuk FYI: f76704a

Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏
I'll soon merge this after the CI finished.

@laysakura laysakura merged commit ade4cae into main Jun 12, 2022
@laysakura laysakura deleted the hide_detail_module_structure branch June 12, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide detail module structure
2 participants