Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split user and app connection factories #173

Conversation

paulsmelser
Copy link
Member

No description provided.

@paulsmelser paulsmelser force-pushed the split_user_and_app_connection_factories branch from bed93d9 to 7f75184 Compare May 28, 2018 17:27
Copy link
Contributor

@jonfk jonfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The createConnection(AccessGrant) method was always returning a PartnerCenterConnection and not AdminPartnerCenterConnection
@paulsmelser paulsmelser force-pushed the split_user_and_app_connection_factories branch from 8121352 to 9c72a17 Compare May 31, 2018 15:25
@paulsmelser paulsmelser deleted the split_user_and_app_connection_factories branch May 31, 2018 15:27
Spring Social for Microsoft Partner Center automation moved this from To do to Done May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants