SPR-10608 Add Path based resource #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Philippe, thanks for the submission and your clear attention to detail! @philwebb, I've assigned the JIRA issue to you for review and merging. I'm recommending that we go with |
FileSystemResource uses the "old" java.io.File instead of the "new" java.nio.file.Path. One of the disadvantages is that it only works with the default file system and not with custom ones. Since the minimum requirement is still Java 6 FileSystemResource can't be retrofitted (and no #getPath can be added to resource). * add PathResource * add PathResourceTests * update Resource with a reference to PathResource PathResource delegates to the underlying file system instead of StringUtils like FileSystemResource. It has therefore slightly different semantics. First when building relative resources via createRelative the relative path will apply to this path (like URL or Unix). If the same switchable behavior like FileSystemResource is wanted that could be done with a boolean switch. Second equality is delegated to the underlying file system provider so it's case-insensitive on Windows. PathResourceTests contains only minimal tests (FileSystemResource has no tests) as writing tests for file code is tricky. I could write more elaborate tests using https://github.com/marschall/memoryfilesystem if that's wanted and OK. Issue: SPR-10608
|
I renamed |
philwebb
added a commit
that referenced
this pull request
Jun 3, 2013
# By Philippe Marschall * SPR-10608-rebase: Introduce java.nio.file.Path based Resource
|
Thanks a lot for this excellent contribution. I have committed it with some minor modifications [1] to master so it should be part of the 4.0 release. [1] philwebb@323ffb2 |
|
Awesome, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSystemResourceuses the "old"java.io.Fileinstead of the "new"java.nio.file.Path. One of the disadvantages is that it only works withthe default file system and not with custom ones. Since the minimum
requirement is still Java 6
FileSystemResourcecan't be retrofitted(and no
#getPathcan be added toResource).PathResourcePathResourceTestsResourcewith a reference toPathResourcePathResourcedelegates to the underlying file system instead ofStringUtilslikeFileSystemResource. It has therefore slightlydifferent semantics. First when building relative resources via
#createRelativethe relative path will apply to this path (like URL orUnix). If the same switchable behavior like
FileSystemResourceiswanted that could be done with a boolean switch. Second equality is
delegated to the underlying file system provider so it's
case-insensitive on Windows.
PathResourceTestscontains only minimal tests(
FileSystemResourcehas no tests) as writing tests forfile code is tricky. I could write more elaborate tests using
https://github.com/marschall/memoryfilesystem if that's wanted and OK.
I did sign the Spring CLA
Issue: SPR-10608