Fix button mappings (a and b were swapped) #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
That's a good catch, however I'm a bit hesitant to merge this as it will reverse the mapping of everyones buttons... if they're already used to where they need to press, this will mess with their motor memory. Any suggestions to stop that from happening? |
|
I think most people won't be updating their badge from master during supercon, so maybe it won't matter. But I think it's worth having the code match the schematics. All the built-in apps could be changed to use the B button instead of A and vice versa, so at least they would be in the same positions? Was the intention to have A on the bottom left and B on the top right like in the image? |
|
Closing bc who cares :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button mapping for A and B was incorrect, this swaps/fixes them. According to the schematic, SW5 is BTN_A and SW6 is BTN_B. (All the bugs on this badge not caught in the prototypes are now official features.)