! Fix elkarte#3677, do not reszie the preview when not asked

Spuds · Apr 2, 2024 · 5aacf73 · 5aacf73
1 parent ae61aaa
commit 5aacf73
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/sources/ElkArte/Controller/Attachment.php b/sources/ElkArte/Controller/Attachment.php
@@ -789,14 +789,15 @@ public function action_tmpattach()
 
 		$this->prepare_headers($filename, $eTag, $mime_type, 'inline', $real_filename, $do_cache);
 
-		if ($resize)
+		// do not resize for ;image
+		if ($resize && !isset($this->_req->query->ila, $this->_req->query->image))
 		{
 			// Create a thumbnail image
 			$image = new Image($filename);
 
 			$filename .= '_thumb';
-			$max_width = $this->_req->isSet('thumb') && !empty($modSettings['attachmentThumbWidth']) ? $modSettings['attachmentThumbWidth'] : 250;
-			$max_height = $this->_req->isSet('thumb') && !empty($modSettings['attachmentThumbHeight']) ? $modSettings['attachmentThumbHeight'] : 250;
+			$max_width = $this->_req->isSet('thumb') && !empty($modSettings['attachmentThumbWidth']) ? $modSettings['attachmentThumbWidth'] : 300;
+			$max_height = $this->_req->isSet('thumb') && !empty($modSettings['attachmentThumbHeight']) ? $modSettings['attachmentThumbHeight'] : 300;
 
 			$image->createThumbnail($max_width, $max_height, $filename, null, false);
 		}

diff --git a/sources/ElkArte/IlaIntegrate.php b/sources/ElkArte/IlaIntegrate.php
@@ -302,7 +302,7 @@ public static function buildTag()
 				$alt = Util::htmlspecialchars($attachment['filename'] ?? 'X');
 				self::$typeTag = '
 					<a id="link_$1" data-lightboximage="$1" data-lightboxmessage="0" href="' . getUrl('action', ['action' => 'dlattach', 'attach' => '$1', 'image']) . '">
-						<img src="' . getUrl('action', ['action' => 'dlattach', 'attach' => '$1']) . $type . '" style="' . $style . '" alt="' . $alt . '" class="bbc_img ' . $class . '" loading="lazy" />
+						<img src="' . getUrl('action', ['action' => 'dlattach', 'attach' => '$1', 'ila' => '1']) . $type . '" style="' . $style . '" alt="' . $alt . '" class="bbc_img ' . $class . '" loading="lazy" />
 					</a>';
 			}
 			// Not an image, determine a mime thumbnail or use a default thumbnail
@@ -328,7 +328,7 @@ public static function buildTag()
 	}
 
 	/**
-	 * This is prevents a little repetition and provides a some control for url tags
+	 * This prevents a little repetition and provides a some control for url tags
 	 *
 	 * - Determines if the ILA is an image or not
 	 * - Keeps track of attachment usage to prevent displaying below the post