Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason #38

Open
astroimagineer opened this issue Dec 4, 2014 · 6 comments
Open

Reason #38

astroimagineer opened this issue Dec 4, 2014 · 6 comments

Comments

@astroimagineer
Copy link

More like a request. Would it be possible to add a reason when giving an award to a member? So the member knows why he got the award from us?

@Spuds
Copy link
Owner

Spuds commented Dec 4, 2014

Something more than just the description of the award? (the description shows up when you hover over an award). Or maybe you want it as an optional PM when its given?

@astroimagineer
Copy link
Author

I remember the version for SMF 1.x. Whenever someone dedicated an award to
another forum member, there was a space to leave a reason. For instance "I
give this award to you for helping me out the other day". In the awards
details screen (awards of a particular user) you could publicly see these
reasons. Maybe it is even possible to add the reason into the tooltip
(hover) in a new line? The suggestion of a PM about the award is cool as
well.

I hope I am not asking too much. Back then we loved this plug in and I am
sooo glad you took it upon yourself to update it to be compatible with
2.0.x ! Thanks for that!

On Thu, Dec 4, 2014 at 5:40 PM, Spuds notifications@github.com wrote:

Something more than just the description of the award? (the description
shows up when you hover over an award). Or maybe you want it as an optional
PM when its given?


Reply to this email directly or view it on GitHub
#38 (comment)
.

@Spuds
Copy link
Owner

Spuds commented Dec 5, 2014

I'll look to add something in the next release, some good ideas there (no I have not idea when that will be 😄 )

I think you may be confusing this mod with some other awards mod, maybe simple awards or other. I looked back at the 1.x line and did not see the capability you describe.

Also to be fair, I did not do the 2.0 conversion, that was done by the previous maintainers of the package. My contribution has been this 3.0 branch which was a bit of a rewrite to add some new options and clean a bunch of things up.

@astroimagineer
Copy link
Author

That's cool! I appreciate your help. I saw that one of the tables already
has an unused comments column. This could surely be used to insert a
reason? Or is this column used to store the reason one gives when
requesting an award?

On Fri, Dec 5, 2014 at 2:30 AM, Spuds notifications@github.com wrote:

I'll look to add something in the next release, some good ideas there (no
I have not idea when that will be [image: 😄] )

I think you may be confusing this mod with some other awards mod, maybe
simple awards or other. I looked back at the 1.x line and did not see the
capability you describe.

Also to be fair, I did not do the 2.0 conversion, that was done by the
previous maintainers of the package. My contribution has been this 3.0
branch which was a bit of a rewrite to add some new options and clean a
bunch of things up.


Reply to this email directly or view it on GitHub
#38 (comment)
.

@Spuds
Copy link
Owner

Spuds commented Dec 5, 2014

Right now that is used to hold the requested reason ... could be converted to what you are suggesting since its under utilized in its current capacity. The requests could be shoved off to its own table.

@astroimagineer
Copy link
Author

Yeah, that sounds good. I've tried looking at the code and I'm just not good enough coding to do it myself. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants