-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable extension in folders where manifest.json is found for bedrock edition #1110
Comments
Yeah, because it's only made for Java Edition data packs. Most of the commands in Bedrock Edition behaviour packs have a completely different syntax. As far as I know, it is not planned at all to support Bedrock behaviour packs. It's not even thought about to be planned in the future. Microsoft themselves have recommended these two extensions for VSCode when making Bedrock Add-Ons:
But these two, however, collide with Java Edition data packs and give you a bunch of errors because they aren't made for Java Edition.* *I do, too, use all three of these extensions. I found that the Bedrock ones give you errors not only in Java Edition data packs but in every other JSON file because it thinks you're trying to define something for a Bedrock Add-Ons. |
I know, I made an issue there too :) Blockception/VSCode-Bedrock-Development-Extension#564 |
Oh, so this issue addresses the fact that it should recognise Bedrock behaviour pack |
Yeah, it would be very cool if this extension checked for |
Would it not be possible to disable the extension in your workspace whenever you're working with Bedrock functions? Explicitly requiring a pack.mcmeta seems like a downgrade, because I would still want lone mcfunction files to receive language support. Maybe we could check for a manifest.json file and disable the language features yourselves? |
I fully agree with that. Otherwise it would be a pretty big downgrade. A super solution whould be to check if the lines, that causes the errors, are valid with bedrock syntax. And then automatically disable highlighting. I know its a whole nother level. At this point Spyglass can almost think about supporting Bedrock Add-Ons. |
That's fair, I'd want lonely function files to work too, although without a pack file it's impossible to know not only which edition it's for, but which version, so that might be annoying |
In IMP Doc v2 (or whatever it ends up being called) we could have a header comment that explicitly declares the function's game version. @vdvman1 @RitikShah Default behavior here shouldn't change at all though unless its a workspace with a bedrock Also, we're not ruling out Bedrock support in this extension, its just not something we're going to be spending time on for a while. |
Moved this to the backlog because this is less urgent now. You can manually specify this folder in |
Just opening a bedrock mcfunction file gives a bunch of errors
![image](https://private-user-images.githubusercontent.com/26075577/321836283-19141edc-9993-48cd-90f7-8256da2d510f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0MTY4NzQsIm5iZiI6MTcyMDQxNjU3NCwicGF0aCI6Ii8yNjA3NTU3Ny8zMjE4MzYyODMtMTkxNDFlZGMtOTk5My00OGNkLTkwZjctODI1NmRhMmQ1MTBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDA1MjkzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE4MzBmYmVkZGU1NzExNzA1YmQ5NGJiMmJkNGRiNzI4YTlkNzhkMjc4YTQ0YmQwY2M2ZjY3MGU1M2U1YmZkZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.efAl9zBAelEpAb8FZCqwDnmvRas1nvgvyn5Z3_0Hp80)
The text was updated successfully, but these errors were encountered: