Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 1.20.5+ item slots #1179

Merged
merged 15 commits into from
May 22, 2024
Merged

Implement 1.20.5+ item slots #1179

merged 15 commits into from
May 22, 2024

Conversation

Nico314159
Copy link
Contributor

@Nico314159 Nico314159 commented May 19, 2024 •
edited

Resolves #1159

MulverineX
MulverineX requested changes May 19, 2024
View reviewed changes
Copy link
Member

@MulverineX MulverineX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions need to use ReleaseVersion.cmp

@MulverineX MulverineX self-requested a review May 19, 2024 02:23
@Nico314159 Nico314159 marked this pull request as draft May 19, 2024 03:38
@Nico314159 Nico314159 self-assigned this May 19, 2024
@Nico314159 Nico314159 marked this pull request as ready for review May 19, 2024 19:52
@Nico314159
Copy link
Contributor Author

Okay, I think I made the whole pipeline work with ctx, but for some reason all the tests are failing...

@Nico314159
Copy link
Contributor Author

@MulverineX Take a look when you get a chance please

misode
misode reviewed May 20, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@misode misode merged commit 2b74e1f into SpyglassMC:main May 22, 2024
3 checks passed
TheAfroOfDoom pushed a commit to TheAfroOfDoom/Spyglass that referenced this pull request May 24, 2024
@Nico314159 @TheAfroOfDoom
Implement 1.20.5+ item slots (SpyglassMC#1179)
12f34c7
TheAfroOfDoom added a commit to TheAfroOfDoom/Spyglass that referenced this pull request May 24, 2024
@TheAfroOfDoom
Squashed commit of the following:
d3705e0 
commit a8431ea
Author: SPGoding <i@spgoding.com>
Date:   Thu May 23 16:54:49 2024 -0500

    🐛 Fix computing relative URIs (SpyglassMC#1177)

commit 0c5e505
Author: Afro <tehafroofdoom@gmail.com>
Date:   Thu May 23 17:53:36 2024 -0400

    🔧 Add `import/no-duplicates` lint rule (SpyglassMC#1181)

commit 50c2185
Author: SPGoding <i@spgoding.com>
Date:   Wed May 22 21:26:34 2024 -0500

    🔥 Remove CommandTreeRegistry (SpyglassMC#1190)

commit 6439d5f
Author: NeunEinser <daniel30797@gmail.com>
Date:   Thu May 23 04:24:54 2024 +0200

    🚧 Remove attributed type in favor of attributes array on all types (SpyglassMC#1182)

commit d99eeb6
Author: SPGoding <i@spgoding.com>
Date:   Wed May 22 21:22:37 2024 -0500

    ⬆️ Upgrade dprint (SpyglassMC#1191)

commit 9a303cc
Author: Afro <tehafroofdoom@gmail.com>
Date:   Wed May 22 22:21:45 2024 -0400

    🔧 Add long timeout arg to unit test launch configuration (SpyglassMC#1189)

commit 2b74e1f
Author: Nico314159 <nicolino.will@gmail.com>
Date:   Wed May 22 13:04:25 2024 -0700

    Implement 1.20.5+ item slots (SpyglassMC#1179)

commit d6c395f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 21 02:58:56 2024 -0500

    ⬆️ Bump rexml from 3.2.5 to 3.2.8 in /docs (SpyglassMC#1153)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a1f81c3
Author: NeunEinser <daniel30797@gmail.com>
Date:   Mon May 20 22:15:26 2024 +0200

    🐛 Fix message reporting breaking on empty string (SpyglassMC#1155)
@misode misode mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPGoding SPGoding SPGoding left review comments

@MulverineX MulverineX MulverineX approved these changes

@misode misode misode approved these changes

Assignees

@Nico314159 Nico314159

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update item slots
4 participants
@Nico314159 @MulverineX @SPGoding @misode