Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster name contains spaces in 'Links' 🤔 #108

Open
mahtoid opened this issue Apr 21, 2024 · 3 comments
Open

Cluster name contains spaces in 'Links' 🤔 #108

mahtoid opened this issue Apr 21, 2024 · 3 comments
Assignees
@Shanomac99
Labels
bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps

Comments

@mahtoid
Copy link

mahtoid commented Apr 21, 2024

image
image
@Shanomac99 Shanomac99 added bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps labels Apr 22, 2024
@Shanomac99 Shanomac99 self-assigned this Apr 22, 2024
@Shanomac99
Copy link
Collaborator

Issue has to do with "objectName" using the actual object name and the LaneLinks (and pointsOrder and listOfMains) utilzing the object's display name. I will be adding an "objectDisplayName" that will be utilized for this. Eventual documentation will note that these use the objects display name.

Shanomac99 added a commit that referenced this issue Apr 22, 2024
@Shanomac99
Fixes #110
ae06999 
Fixes #107
Fixes #108
- Adds a new key "objectDisplayName" to objectives.
@mahtoid
Copy link
Author

mahtoid commented Apr 22, 2024

@Shanomac99 is there no way to use the display name to capture but extract the actual object name only? I don't see a valid data use case where someone would be wanting to mix-match between the two.

You'd only reference links for the cluster. Seems weird to have to go objectDisplayName ?? objectName - but I mean, it still works 🤷

@Shanomac99
Copy link
Collaborator

I took a closer look. almost everything is using objectDisplayName currently. From the looks of things only the clusters are using objectName. It probably makes more sense to move over utilizing objectDisplayName for them versus changing every else to objectName.

Shanomac99 referenced this issue Jun 17, 2024
@Shanomac99
Update to 8.0
0a51f66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shanomac99 Shanomac99

Labels
bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shanomac99 @mahtoid