Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My fixes for the Magritte booklet #2

Merged
merged 4 commits into from Apr 24, 2018

Conversation

luque
Copy link
Contributor

@luque luque commented Apr 24, 2018

Hi Stef,

I've reviewed the entire booklet and followed the exercises.

In this pull request I've included some little fixes I could commit directly.

By the other way, here are some other comments that didn't fit well in the pull request:

1. I've found the root cause of the error when click on editView. It's necessary to remove:

componentClass: MAInternalEditorComponent

in the descriptionHomeAddress method.

2. At least in my case, Magritte was not installed when I install Seaside3 (using the Catalog), so I had to install manually Magritte-Seaside after install Seaside.

3. In section 2.4 (page 10), it is not clear how to get the web application running as expected in the figure 2-2. I think is missing the code to register the application. Something like:

WAAdmin register: self asApplicationAt: 'address'

4. I think some exercises are out of order. In particular, I think the Exercise 6 should go before all exercises in Chapter 4, because until the exercise 6 you still don't code a Seaside componente, however the Chapter 4 exercises refer to snapshots of the Seaside component.

@Ducasse
Copy link
Member

Ducasse commented Apr 24, 2018

Hi rafael
Thanks a lot. I'm focusing on the migration of the seaside book and getting the tinyblog book out and magritte is the next on the list.

Stef

@Ducasse Ducasse merged commit 5a902fc into SquareBracketAssociates:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants