Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish chapter "Most of Spec in one example" #94

Merged
merged 2 commits into from
May 4, 2024

Conversation

koendehondt
Copy link
Collaborator

@koendehondt koendehondt commented May 4, 2024

This is the PR for #73.

It was quite some work to finish this long chapter. 😅

@koendehondt koendehondt requested a review from Ducasse May 4, 2024 16:10
@koendehondt
Copy link
Collaborator Author

@Ducasse If you do not have any comments or suggestions, I consider the chapter "Most of Spec in one example" to be finished. One more done! 😎

@Ducasse
Copy link
Member

Ducasse commented May 4, 2024

I will have a look and indeed it is long and it cost me time also in the past.

@Ducasse
Copy link
Member

Ducasse commented May 4, 2024

I read the complete chapter in speed mode and it looks good to me.

@Ducasse Ducasse merged commit 0952e69 into master May 4, 2024
1 check passed
@koendehondt koendehondt deleted the finish-most-of-spec-in-one-example branch May 5, 2024 08:48
@koendehondt
Copy link
Collaborator Author

@Ducasse I overlooked that a test did not pass anymore after changing #setModel: to cope with a nil argument. I adapted the test and changed it in the book and in the code repo. I pushed the changes to the two master branches.

@Ducasse
Copy link
Member

Ducasse commented May 5, 2024

Cool!
I'm massively cleaning my house after the facade renewal (dust everywhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants