Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent code presentation #60

Closed
wants to merge 1 commit into from

Conversation

cdlm
Copy link
Member

@cdlm cdlm commented Jan 31, 2016

Have we decided on the amount of indentation in listings? I can update chapter while I read/edit them, but that's going to be a huge patch. The thing that I find most disturbing is that some listings do not align with the previous paragraph, because the code is indented inside the pillar markup. Now that there is a line at the left margin, it makes it even more obvious.

Same for result arrows, some chapters use -->, some use ->

@Ducasse
Copy link
Member

Ducasse commented Jan 31, 2016

On 31 Jan 2016, at 04:01, Damien Pollet notifications@github.com wrote:

Have we decided on the amount of indentation in listings? I can update chapter while I read/edit them, but that's going to be a huge patch. The thing that I find most disturbing is that some listings do not align with the previous paragraph, because the code is indented inside the pillar markup. Now that there is a line at the left margin, it makes it even more obvious.

Same for result arrows, some chapters use -->, some use ->

for —> and ->
I would always use

on the following line
I found the —> substitution annoying because when we change lib we may not have if.

Damien I would like to have >> as >> and not > >


Reply to this email directly or view it on GitHub.

@DamienCassou
Copy link
Contributor

Code should start at column 0. I propose we indent with 3 spaces, that what we did for the mooc.

@cdlm
Copy link
Member Author

cdlm commented Jan 31, 2016

Ok then my commit above is incorrect, it uses 2 spaces.

@DamienCassou
Copy link
Contributor

I'm ok with 2 spaces too. Can you please fix your PR?

@DamienCassou
Copy link
Contributor

Ok, I did it for the whole book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants