Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually implement GitHub oauth #100

Merged
merged 2 commits into from Oct 6, 2015
Merged

Actually implement GitHub oauth #100

merged 2 commits into from Oct 6, 2015

Conversation

gilbert
Copy link
Contributor

@gilbert gilbert commented Oct 3, 2015

Closes #95

@jmarthernandez
Copy link
Contributor

@mindeavor Do we want to call sync user every time we log?

@gilbert
Copy link
Contributor Author

gilbert commented Oct 4, 2015

I think yes, since we're sourcing avatar urls from GitHub.

jmarthernandez added a commit that referenced this pull request Oct 6, 2015
@jmarthernandez
Merge pull request #100 from SquashLog/fix/oauth
b7c9f99 
Actually implement GitHub oauth
@jmarthernandez jmarthernandez merged commit b7c9f99 into master Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbert @jmarthernandez