use false for the error object for when things go well, instead of null

AlexJWayne · Jan 13, 2012 · f7215b1 · f7215b1
1 parent cd5ae61
commit f7215b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/coffeeson.coffee b/coffeeson.coffee
@@ -23,7 +23,7 @@ fileToJSON = (name, args..., cb) ->
   fs.readFile name, (err, src) ->
     if cb
       return cb err if err
-      cb null, toJSON(src, args...)
+      cb no, toJSON(src, args...)
   return
 
 # Asynchronously read a file and callback with the content as pretty JSON
@@ -36,7 +36,7 @@ convertFile = (name, args..., cb) ->
     fs.writeFile name.replace(/\.coffeeson$/, '.json'), json, (err) ->
       if cb
         return cb err if err
-        cb null, json
+        cb no, json
   return
 
 # Asynchronously read a file and save a pretty .json file right next the source file

diff --git a/test/coffeeson_test.coffee b/test/coffeeson_test.coffee
@@ -69,7 +69,7 @@ describe 'coffeeson', ->
   it '.convertFile() async reads a coffeeson file and writes a json file right next to it', (done) ->
     coffeeson.convertFile 'test/sample.coffeeson', (err) ->
       # ensure no error
-      (!!err).should.not.be.ok # should.js wtf?
+      err.should.not.be.ok
 
       # Ensure the file was written
       path.exists 'test/sample.json', (exists) ->
@@ -85,7 +85,7 @@ describe 'coffeeson', ->
   it '.convertFilePretty() async reads a coffeeson file and writes a pretty json file right next to it', (done) ->
     coffeeson.convertFilePretty 'test/sample.coffeeson', (err) ->
       # ensure no error
-      (!!err).should.not.be.ok # should.js wtf?
+      err.should.not.be.ok
 
       # Ensure the file was written
       path.exists 'test/sample.json', (exists) ->