Created Footer #14
Created Footer #14
Conversation
|
Attach screenshot of your changes in the description |
next.config.js
Outdated
There was a problem hiding this comment.
Revert it back to original. No need to write this.
pages/_app.tsx
Outdated
There was a problem hiding this comment.
Don't add Footer in _app.tsx. Add it in index.tsx.
There was a problem hiding this comment.
Footer.tsx removed from _app.tsx and added in index.tsx.
components/commons/Footer/Footer.tsx
Outdated
| import { FooterProps as Props } from "./Footer.types"; | ||
| import Squirrel from "./assets/Squirrel.png"; |
There was a problem hiding this comment.
Spelling of image name corrected.
There was a problem hiding this comment.
Spelling of image name corrected.
package.json
Outdated
| "typescript": "4.9.5" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Remove it as dev-dependency, and install it back as normal dependency. To do that:
npm uninstall sassnpm i sass
There was a problem hiding this comment.
Removed sass as dev-dependency and added as normal dependency.
There was a problem hiding this comment.
@FaizBShah I was curious why choose to install it as normal dependency. It is required only for development purposes and no need to install this in production right?
There was a problem hiding this comment.
@BIKRAM-SAHA You're correct. I don't remember why but I think it was to keep the packages consistent since I was experimenting with the boilerplate, and didn't wanted to get errors and waste time figuring out which dependencies can work in dev-mode and which can work in in prod mode. But now I think barring 4 (next, react, react-dom, react-router-dom), all of them could be installed as dev-dependency, as none of them will be actually required in the production build. (If we actually required typescript in production, my life would had been so much better :p)
|
Fixes #6
Footer created.