Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigurable terminal sizes #112

Closed
Lemmmy opened this issue Feb 13, 2019 · 4 comments · Fixed by #475
Closed

Reconfigurable terminal sizes #112

Lemmmy opened this issue Feb 13, 2019 · 4 comments · Fixed by #475
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.

Comments

@Lemmmy
Copy link
Member

Lemmmy commented Feb 13, 2019

This was previously mentioned on dan200/ComputerCraft#188 and dan200/ComputerCraft#213, though both ideas were quickly tossed out. I think that the latter issue there is referring more to increased pixel density, rather than an increased terminal size.

I think that, at the very least, the maximum monitor size should be reconfigurable server-side (in blocks). Regular terminals (Computers and Pocket Computers, in characters) would be nice too, though with the obvious note that they may get too large for users' screens. Turtles (and Plethora's Neural Interfaces) are obviously unconfigurable (or rather, pointlessly difficult to implement) due to their GUI.

If I recall correctly, the terminal size used to be reconfigurable, though I'm unsure why that functionality was removed (if it ever existed in the first place).

To be clear: I am not requesting that terminals can be dynamically resized in any way, but rather, configurable server-side.

@SquidDev SquidDev added the enhancement An extension of a feature or a new feature. label Feb 13, 2019
@SquidDev
Copy link
Member

As mentioned in the second issue there, it's definitely something I'd like to add, but I'd quite like to optimise the network traffic of monitors and computers first. We currently send the whole terminal each time, which ends up being rather expensive.

@SquidDev

This comment has been minimized.

@SquidDev SquidDev added the area-Minecraft This affects CC's Minecraft-specific content. label Jun 5, 2019
@Jummit
Copy link
Contributor

Jummit commented Jun 16, 2020

Is this a possibility as of #453 ?

@SquidDev
Copy link
Member

Yeah, I guess?

SquidDev added a commit that referenced this issue Jun 19, 2020
This allows for configuring the size of computers, turtles and pocket
computers, as well as the max size of monitors. It's currently a little
broken, as we do not correctly handle resizing the GUI. Turtles
especially suffer from this.

See #112
@SquidDev SquidDev linked a pull request Jun 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants