Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress #200

Closed
tborychowski opened this issue Mar 8, 2017 · 15 comments
Closed

Download progress #200

tborychowski opened this issue Mar 8, 2017 · 15 comments

Comments

@tborychowski
Copy link

Is it possible to get a download progress event of some sort?
I'm using electron-builder auto updater, which is using Squirrel.Mac under the hood, and I cannot get the download progress, because apparently Squirrel does not provide it.

@develar
Copy link

develar commented Mar 8, 2017

Some clarification: electron-updater wraps official bundled auto-updater on macOS to get rid of special server requirements. Alongside other features. On Windows NSIS is used and, so, it is very easy to implement progress.

@igor-lemon
Copy link

+1

2 similar comments
@796F
Copy link

796F commented Apr 9, 2017

+1

@thegnuu
Copy link

thegnuu commented Apr 19, 2017

+1

@biroplane
Copy link

biroplane commented Apr 24, 2017

@develar can you explain "how easy can be to implement the progress"?! thanks

@jessica-pixvana
Copy link

+1

@develar
Copy link

develar commented May 30, 2017

  1. Please use reactions instead of comments +1.
  2. electron-builder auto-updater supports progress events — it will be released in 2 weeks. Stay tuned :)

@biroplane
Copy link

will you share with the rest of us the implementation, please? :)

@ghost
Copy link

ghost commented Jun 5, 2017

atom/atom#9164

@ghost
Copy link

ghost commented Jun 5, 2017

For the +1 out there, here's the reason why @develar made his comment so you have some context: https://github.com/dear-github/dear-github

@develar
Copy link

develar commented Jun 5, 2017

@biroplane electron-userland/electron-builder#1167 (comment)

Users of electron-builder / electron-updater — you are not affected by this issue anymore.

@develar
Copy link

develar commented Jun 5, 2017

If you for some reasons don't use electron-builder — electron-updater can be used standalone, but you will need to generate sha512 field in the update info file. This requirement can be relaxed if need. Feed url in the electron-updater it is url to dir, where channel update info file is expected (latest channel by default). e.g. feed url https://example.com -> https://example.com/latest-mac.yml file will requested (in case of generic provider).

I decided to not implement this logic on the native side, but in userland, because in this case user can use standard electron net API and customize behaviour (auth, redirect, proxy and so on).

@zjfjiayou
Copy link

+1

@zjfjiayou
Copy link

Thank you @develar, I find this problem for a long time, thank you have to fix the problem。https://github.com/electron-userland/electron-builder/tree/master/packages/electron-updater

@tborychowski
Copy link
Author

I have another way to make it work now, so no need for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants