Error if there's an update available but the app's on a read-only volume #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithduncan
requested changes
Oct 17, 2016
| @@ -32,6 +33,9 @@ | |||
| const NSInteger SQRLUpdaterErrorInvalidJSON = 6; | |||
| const NSInteger SQRLUpdaterErrorInvalidServerBody = 7; | |||
|
|
|||
| /// The application's being run on a read-only volume. | |||
| const NSInteger SQRLUpdaterErrorReadOnlyVolume = 7; | |||
There was a problem hiding this comment.
Should this be 8 to distinguish from SQRLUpdaterErrorInvalidServerBody
| BOOL readOnlyVolume = [self isRunningOnReadOnlyVolume]; | ||
| if (readOnlyVolume) { | ||
| NSDictionary *errorInfo = @{ | ||
| NSLocalizedDescriptionKey: NSLocalizedString(@"Read-only volume", nil), |
There was a problem hiding this comment.
Could you make this @"Cannot update while running on a read-only volume"
| - (BOOL)isRunningOnReadOnlyVolume { | ||
| struct statfs statfsInfo; | ||
| NSURL *bundleURL = NSRunningApplication.currentApplication.bundleURL; | ||
| statfs(bundleURL.fileSystemRepresentation, &statfsInfo); |
There was a problem hiding this comment.
This syscall should be error handled, should we default to true in the error case?
|
🗝 |
|
|
keithduncan
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #182
I think it makes sense to only error once we know that it matters, i.e., that there's an update available. Otherwise it'd just be an annoying error when the user first downloads the app.
The read-only volume check is taken from Sparkle: https://github.com/sparkle-project/Sparkle/blob/3a5c620b60f483b71f8c28573ac29bf85fda6193/Sparkle/SUHost.m#L178-L183