Update: Ensure we don't create stub for generated stub executables #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
reviewed
Jul 27, 2018
anaisbetts
reviewed
Jul 27, 2018
anaisbetts
reviewed
Jul 27, 2018
| return rootPath.GetAllFilesRecursively("*"); | ||
| } | ||
|
|
||
| public static IEnumerable<FileInfo> GetAllFilesRecursively(this DirectoryInfo rootPath, string searchPattern) |
There was a problem hiding this comment.
Why is this a function now? It does the same thing
There was a problem hiding this comment.
The idea is to have an overload that takes the search pattern as a parameter (to be used when collectiong exe files for stub creation)
|
What does this do? Can you fill in the description describing what problem this is trying to solve? |
|
Hey @paulcbetts , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
If we have a lot of files that are enumerated through the call to GetAllFilesRecursively we end up in the situation where we also enumerate over the newly created stub executables.
From this point two thing happen:
Fix:
To ensure this does not happen we force a call to ToList() such that we get the list of executables for which to create the stubs.