Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging to Releasify #1432

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Jan 2, 2019

  1. Add Logging to Releasify

    The following refactor was brought about because we (Age Partnership)
    were running into difficulty using Squirrel in the Azure DevOps Build
    Pipelines and existing logging wasn't sufficient for our needs.
    
    I don't expect any functionality to have changed.
    
    The Releasify method in Update.exe has been broken up into;
    
    * ensureConsole
    * ReleasifyValidateBaseUrl
    * ReleasifyValidatePaths
    * ReleasifyPrepareFiles
    * ReleasifyProcessFiles
    * ReleasifyCleanupFiles
    * ReleasifyWriteReleaseFile
    * ReleasifyCreateSetupExe
    * ReleasifyGenerateMsi
    
    Breaking Releasify up into smaller methods allows stack traces to be
    more useful when identifying issues.
    
    The refactoring was done using ReSharper. Only significant change is the
    use of `out var` declarations and passing variables using `ref`. I
    expect a more significant refactor could make this cleaner.  Debug logs have
    been added to the start of each method and the whole Releasify method is now
    in a "try / catch / log / throw" block.
    Horb committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    5ba59ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    875fe58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df3e46c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    67fa86e View commit details
    Browse the repository at this point in the history
  5. Revert "Build: Fix Reference HintPaths."

    This reverts commit d3b0deb.
    Horb committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    df8d964 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    17314f2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f184389 View commit details
    Browse the repository at this point in the history
  8. Rearrange to reduce diff.

    Horb committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    ed47148 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Configuration menu
    Copy the full SHA
    06fc423 View commit details
    Browse the repository at this point in the history