Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to package.Id if title not available #1447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fallback to package.Id if title not available #1447

wants to merge 1 commit into from

Commits on Feb 14, 2019

  1. Fallback to package.Id if title not available 

    If a package title is not set in the nuspec tile, normal user installs work fine, but the installation folder set in the Wix for the machine wide installer becomes "%programfiles%\ Installer\ .... " - note the space where the title should be. 

When the folder is created this space is silently removed by the operating system, however in the registry Run entry, the space is present. As the name in the registry and the actual path don't match, the machine wide installer never runs. 

This change means that the installer falls back to using the id if the name is not available
    @james1465
    james1465 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    6a19a6b View commit details
    Browse the repository at this point in the history