-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Fedora packaging #7
base: main
Are you sure you want to change the base?
Conversation
I've started with Also note the comments in commit 540aba2 |
2ed6907
to
bcf3cd5
Compare
Here is my workflow for adding these: $ export rust_pkg=...
$ mkdir ../rust-${rust_pkg} && cd ../rust-${rust_pkg} && touch rust2rpm.toml && rust2rpm ${rust_pkg} After which I check https://bugzilla.redhat.com/ for any open review requests and https://crates.io/ for some other links.
|
f2d0bae
to
e19d3c1
Compare
acef2e6
to
f824b03
Compare
e3d42de
to
58d7fa1
Compare
/packit build |
Downstream has made quite some progress, the main blocker was
|
5bdd6b3
to
2c8f77a
Compare
I'm also seeing that axum is failing to build. Looks like we may need to make some inquiries to downstream or patch the dependency down to 0.4.4. Thanks for your continued work on this! |
Yeah, that whole dependency tree is being worked on downstream |
Status update:
|
7fd7216
to
4cba42b
Compare
Only remaining issue is with |
f43a99b
to
2f0796e
Compare
Seems the tests that are done now were not run in the vendored case because |
Notes to self: maybe the sqlite tests are fixed by: launchbadge/sqlx#362 (comment) |
Just a heads up that the actual fix for the SQLite test failure is to enable SQLITE_USE_URI in your SQLite build Void had the same issue here: https://forum.atuin.sh/t/packaging-atuin-for-void-linux/20/9 |
d54bd86
to
888febd
Compare
Yes, I've opened a bug about it and asking other packagers for feedback: https://bugzilla.redhat.com/show_bug.cgi?id=2291157 |
@SriRamanujam btw, don't merge this one, because it would be good to have the vendored version for copr instead that is better supported. Just need this on a separate branch or in the current PR as-is so I can link to the spec and srpm files. I plan to submit the rest of the package reviews the week after. This week is DevConf. |
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Too many build dependencies to handle Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
888febd
to
8a940d2
Compare
Now to handle the dependencies themselves an prepare for packaging