Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Fedora packaging #7

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LecrisUT
Copy link
Contributor

Now to handle the dependencies themselves an prepare for packaging

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 28, 2024

I've started with argon2 as a template on how to resolve the dependencies. Packit does not have proper dependencies support, but restarting the build should pick up the latest version

Also note the comments in commit 540aba2

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 2 times, most recently from 2ed6907 to bcf3cd5 Compare March 28, 2024 13:38
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 28, 2024

Here is my workflow for adding these:

$ export rust_pkg=...
$ mkdir ../rust-${rust_pkg} && cd ../rust-${rust_pkg} && touch rust2rpm.toml && rust2rpm ${rust_pkg}

After which I check https://bugzilla.redhat.com/ for any open review requests and https://crates.io/ for some other links.

  • If the package has a review request, add a link, remove the rust2rpm.toml, and copy the spec file from the link
  • If the package is already in fedora, copy the spec file and rust2rpm.toml (update the .conf file if necessary) and rerun rust2rpm ${rust_pkg}
  • If none of the above are the case, proceed with the files generated

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 2 times, most recently from f2d0bae to e19d3c1 Compare March 28, 2024 15:03
@LecrisUT LecrisUT marked this pull request as ready for review March 28, 2024 15:56
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 6 times, most recently from acef2e6 to f824b03 Compare March 28, 2024 20:13
@LecrisUT LecrisUT marked this pull request as draft March 28, 2024 20:29
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 4 times, most recently from e3d42de to 58d7fa1 Compare March 29, 2024 20:28
@LecrisUT
Copy link
Contributor Author

/packit build

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Apr 25, 2024

Downstream has made quite some progress, the main blocker was sqlx which has quite a lot of dependencies, and now there only futures-intrusive is blocking. The main dependencies we need to work on fixing are:

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 2 times, most recently from 5bdd6b3 to 2c8f77a Compare April 26, 2024 08:41
@SriRamanujam
Copy link
Owner

Downstream has made quite some progress, the main blocker was sqlx which has quite a lot of dependencies, and now there only futures-intrusive is blocking. The main dependencies we need to work on fixing are:

* [x]  sqlx: https://github.com/LecrisUT/sqlx-rpmspec

* [ ]  rusty_paserk

* [ ]  rusty_paseto

* [ ]  metrics

* [ ]  metrics-exporter-prometheus

* [ ]  interim

* [ ]  cli-clipboard

* [ ]  parse_duration: Probably need to patch dependency of `num`?

I'm also seeing that axum is failing to build. Looks like we may need to make some inquiries to downstream or patch the dependency down to 0.4.4.

Thanks for your continued work on this!

@LecrisUT
Copy link
Contributor Author

Yeah, that whole dependency tree is being worked on downstream

@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 28, 2024

Status update:

  • sqlx chain is basically finished
  • rusty_paserk, rusty_paseto chain is almost finished
  • metrics chain is almost finished
  • interim, cli-clipboard, parse_duration have a simple dependency chain, should be straightforward to do (if my notes about it are still accurate)

@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 4 times, most recently from 7fd7216 to 4cba42b Compare May 30, 2024 09:55
@LecrisUT
Copy link
Contributor Author

LecrisUT commented May 30, 2024

Only remaining issue is with cli-clipboard: allie-wake-up/cli-clipboard#21. We have an alternative

@LecrisUT LecrisUT marked this pull request as ready for review May 30, 2024 10:07
@LecrisUT LecrisUT force-pushed the review/rust-dependencies branch 12 times, most recently from f43a99b to 2f0796e Compare May 31, 2024 13:56
@LecrisUT
Copy link
Contributor Author

Seems the tests that are done now were not run in the vendored case because cargo_install_lib 0. But I don't see it referencing postgres in this case :/

@LecrisUT
Copy link
Contributor Author

Notes to self: maybe the sqlite tests are fixed by: launchbadge/sqlx#362 (comment)

@ellie
Copy link

ellie commented Jun 10, 2024

Just a heads up that the actual fix for the SQLite test failure is to enable SQLITE_USE_URI in your SQLite build

Void had the same issue here: https://forum.atuin.sh/t/packaging-atuin-for-void-linux/20/9

@LecrisUT
Copy link
Contributor Author

Yes, I've opened a bug about it and asking other packagers for feedback: https://bugzilla.redhat.com/show_bug.cgi?id=2291157

@LecrisUT LecrisUT marked this pull request as draft June 10, 2024 13:57
@LecrisUT LecrisUT changed the title feat: Fedora packaging [Do not merge] Fedora packaging Jun 10, 2024
@LecrisUT
Copy link
Contributor Author

@SriRamanujam btw, don't merge this one, because it would be good to have the vendored version for copr instead that is better supported. Just need this on a separate branch or in the current PR as-is so I can link to the spec and srpm files. I plan to submit the rest of the package reviews the week after. This week is DevConf.

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Too many build dependencies to handle

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants