converted the class based component to functional component #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @webcoderspeed, Looks like you have mistakenly removed the package-lock.json file as well, please revert it. |
|
readded |
SscSPs
requested changes
Oct 8, 2022
src/ColorPickerComponent.js
Outdated
| <div> | ||
| <ColorGrid | ||
| hueCount={colorAsHSL[0]} |
There was a problem hiding this comment.
its hueValue, not count.
satCount and lumCount were for the grid, and h was for the hue to work with, please update the name of hueCount to hueValue
SscSPs
approved these changes
Oct 8, 2022
|
Thanks for the code change! |
|
yeh hacktoberfest mei accepted nhi hui bhai. |
|
It updates every 30 minutes or so(not entirely sure), the dashboard will be updated soon(if not already done) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue