Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bowtie2 added #251

Merged
merged 4 commits into from
Oct 5, 2021
Merged

bowtie2 added #251

merged 4 commits into from
Oct 5, 2021

Conversation

DOH-HNH0303
Copy link
Contributor

With samtools included to immediately convert sam files to bam files

with samtools for to immediately convert sam to bam files
@kapsakcj
Copy link
Collaborator

Hi Holly, thanks for the PR. This is an essential bioinfo tool that is missing from our collection.

I was able to build the docker image successfully and was able to align some single end sars-cov-2 reads to it's assembly, followed by samtools view [...] & samtools sort [...] which ran as expected. Everything checks out on my end ✔️

I have some minor suggestions for the dockerfile that I would like to put forward before we merge the PR and build the image on dockerhub and quay. I'll make comments on the dockerfile & README.md

README.md Outdated Show resolved Hide resolved
bowtie2/2.4.4/Dockerfile Outdated Show resolved Hide resolved
bowtie2/2.4.4/Dockerfile Outdated Show resolved Hide resolved
@kapsakcj
Copy link
Collaborator

OK, I made my comments. Please let me know if you have any questions or if I can clarify anything.

Thank you!

@DOH-HNH0303
Copy link
Contributor Author

Changes were made as suggested and tested locally. Thanks for your feedback!

@kapsakcj
Copy link
Collaborator

kapsakcj commented Oct 5, 2021

Awesome, thank you. Tested out great on my end again. I will merge and push to dockerhub and quay.

@kapsakcj kapsakcj merged commit bea58c6 into StaPH-B:master Oct 5, 2021
@kapsakcj
Copy link
Collaborator

kapsakcj commented Oct 5, 2021

The docker image is now available on dockerhub and quay. Thank you for the PR!

https://hub.docker.com/r/staphb/bowtie2/tags?page=1&ordering=last_updated

https://quay.io/repository/staphb/bowtie2?tab=tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants