Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding parsnp 2.0.5 #980

Merged
merged 1 commit into from
May 22, 2024
Merged

adding parsnp 2.0.5 #980

merged 1 commit into from
May 22, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of parsnp!

According to the release notes:

Parsnp now outputs a MAF file in addition to the typical XMFA file (can turn this off with (--no-maf).
Parsnp now uses the partition mode by default when there are more than 100 input sequences.

All I did was copy the Dockerfile from version 2.0.4 and update the software arg.

The full diff:

$ diff parsnp/2*/Dockerfile
1c1
< ARG PARSNP_VER="2.0.4"
---
> ARG PARSNP_VER="2.0.5"

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Collaborator

@erinyoung I realized that parsnp searches FastTreeMP which can improve overall performance.
Have you tried to install FastTreeMP instead of Fasttree?

#26 72.27 19:59:06 - INFO - FastTreeMP not found. Trying fasttree...
#26 72.27 19:59:06 - DEBUG - fasttree -nt -quote -gamma -slow -boot 100 outdir_parsnp_fasttree/parsnp.snps.mblocks

@erinyoung
Copy link
Contributor Author

I'm going to pass installing FastTreeMp (http://www.microbesonline.org/fasttree/#OpenMP) because it involves installing fasttree from source instead of just downloading the executable.

@Kincekara
Copy link
Collaborator

@erinyoung precompiled executable is available here: http://www.microbesonline.org/fasttree/FastTreeMP
I am merging this now. We can check FastTreeMP in the next iteration.

@Kincekara Kincekara merged commit aa8cb89 into master May 22, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the update!
Deploy link: https://github.com/StaPH-B/docker-builds/actions/runs/9191921039.

@erinyoung erinyoung deleted the erin-parsnp branch May 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants