remove stray quotation marks in question_full.jsonll
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polm-stability
pushed a commit
to polm-stability/FastChat
that referenced
this pull request
Mar 1, 2024
change completion
|
@polm-stability @leemengtw |
|
Sorry for never replying to this! Not sure how I missed either the initial issue with the quote or this PR. It looks like a good fix to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There is a stray quotation mark in JSON format in
question_full.jsonlso that one raises error onjson.load()Related issue number (if applicable)
none
Checks
format.shto lint the changes in this PR.