-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upscale #186
Merged
Merged
Upscale #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharmapsychotic
previously approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach to allow future expansion to the command line tool while exposing upscale.
TODO before merge:
|
Co-authored-by: pharmapsychotic <96542870+pharmapsychotic@users.noreply.github.com>
Co-authored-by: pharmapsychotic <96542870+pharmapsychotic@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
pharmapsychotic
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upscaler added to client
Notable change:
Command line call has been modified!
From:
to
Backwards compatibility has been (mostly) maintained with a hack here:
stability-sdk/src/stability_sdk/client.py
Line 529 in 9c29755
Usage
The client is initialized with an upscale_engine (default "esrgan-v1-x2plus").
As illustrated in the notebook, the upscaler can be invoked with:
Default output image size depends on the upscale_engine (x2 for esrgan-v1-x2plus). Optionally, a height or width can be requested to specify output size:
Do not specify both a height and width, only specify one or neither. This is to preserve the aspect ratio of the original image.