SubprocVecEnv close fix. Fixes #898 (#899)

* Add a seed() method to vectorized environments (fixes #675). * Updated Changelog * Updated Changelog (again) and added type hints. * Update docstring * Added curiosity wrapper. * Fixed imports. * Fix for SubprocVecEnv closing. Updated changelog. * Better changelog. * Removed curiosity from fixes branch. Co-authored-by: NeoExtended <wirspielen@web.de> Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
Stable-Baselines-Team · Jun 20, 2020 · d288b6d · d288b6d
1 parent 0c956eb
commit d288b6d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/docs/misc/changelog.rst b/docs/misc/changelog.rst
@@ -33,6 +33,7 @@ Bug Fixes:
 - Fixed a bug in ``SAC`` where any convolutional layers were not included in the target network parameters.
 - Fixed ``render()`` method for ``VecEnvs``
 - Fixed ``seed()``` method for ``SubprocVecEnv``
+- Fixed a bug in the ``close()`` method of ``SubprocVecEnv``, causing wrappers further down in the wrapper stack to not be closed. (@NeoExtended)
 
 Deprecations:
 ^^^^^^^^^^^^^

diff --git a/stable_baselines/common/vec_env/subproc_vec_env.py b/stable_baselines/common/vec_env/subproc_vec_env.py
@@ -29,6 +29,7 @@ def _worker(remote, parent_remote, env_fn_wrapper):
             elif cmd == 'render':
                 remote.send(env.render(data))
             elif cmd == 'close':
+                env.close()
                 remote.close()
                 break
             elif cmd == 'get_spaces':