Skip to content

Commit

Permalink
Remove custom cartpole (#813)
Browse files Browse the repository at this point in the history
* Remove custom_cartpole.py

- Remove calls to custom cartpole
- hill-a/stable-baselines#810
- hill-a/stable-baselines#812

* Update changelog.rst

* Update Changlog

- move changes from deprecations to documentations

* Update changelog.rst

Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
  • Loading branch information
aakash94 and araffin committed Apr 19, 2020
1 parent 77acee0 commit d699d6f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 107 deletions.
3 changes: 2 additions & 1 deletion docs/misc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Documentation:
^^^^^^^^^^^^^^
- Fix typos (@caburu)
- Fix typos in PPO2 (@kvenkman)
- Removed ``stable_baselines\deepq\experiments\custom_cartpole.py`` (@aakash94)


Release 2.10.0 (2020-03-11)
Expand Down Expand Up @@ -691,4 +692,4 @@ Thanks to @bjmuld @iambenzo @iandanforth @r7vme @brendenpetersen @huvar @abhiskk
@XMaster96 @kantneel @Pastafarianist @GerardMaggiolino @PatrickWalter214 @yutingsz @sc420 @Aaahh @billtubbs
@Miffyli @dwiel @miguelrass @qxcv @jaberkow @eavelardev @ruifeng96150 @pedrohbtp @srivatsankrishnan @evilsocket
@MarvineGothic @jdossgollin @SyllogismRXS @rusu24edward @jbulow @Antymon @seheevic @justinkterry @edbeeching
@flodorner @KuKuXia @NeoExtended @solliet @mmcenta @richardwu @tirafesi @caburu @johannes-dornheim @kvenkman
@flodorner @KuKuXia @NeoExtended @solliet @mmcenta @richardwu @tirafesi @caburu @johannes-dornheim @kvenkman @aakash94
101 changes: 0 additions & 101 deletions stable_baselines/deepq/experiments/custom_cartpole.py

This file was deleted.

5 changes: 0 additions & 5 deletions tests/test_deepq.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from stable_baselines.deepq.experiments.custom_cartpole import main as main_custom
from stable_baselines.deepq.experiments.train_cartpole import main as train_cartpole
from stable_baselines.deepq.experiments.enjoy_cartpole import main as enjoy_cartpole
from stable_baselines.deepq.experiments.train_mountaincar import main as train_mountaincar
Expand All @@ -17,10 +16,6 @@ class DummyObject(object):
args.max_timesteps = 200


def test_custom_cartpole():
main_custom(args)


def test_cartpole():
train_cartpole(args)
enjoy_cartpole(args)
Expand Down

0 comments on commit d699d6f

Please sign in to comment.