Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scss): Add toaster.scss and node-sass compilator #143

Merged
merged 2 commits into from Feb 22, 2018

Conversation

bastienmoulia
Copy link
Contributor

I add a toaster.scss with node-sass to generate the CSS file (no change on that).

I put some variables in it (colors, icons, breakpoints) which are the main ones modified for me. But others can be added too.

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 488a38e on bastienmoulia:patch-scss into c8cdc2d on Stabzs:5.x.x/Target_Angular_5.

@Stabzs
Copy link
Owner

Stabzs commented Feb 6, 2018

@bastienmoulia thanks a ton for doing this! This was on my backlog and I haven't been able to get to it yet so it is much appreciated!

Two things, if you could please:

  1. It looks like some of the background images have shifted based on the regenerated toaster.css diff. Could you please double check those base 64 strings?

  2. I'd like to fold this into the 5.x.x branch instead of master and push a second alpha build/package to confirm the final generation. This would then get pushed into the 5.x.x as a full release pending the current alpha validation which I should be wrapping up this week.

Thanks again!

@bastienmoulia
Copy link
Contributor Author

@Stabzs Due to the order in the SCSS map, the class icon-* are not in the same order, but the images should be good.

I can make a PR in the branch 5.x.x this evening.

@bastienmoulia bastienmoulia changed the base branch from master to 5.x.x/Target_Angular_5 February 6, 2018 21:17
@Stabzs
Copy link
Owner

Stabzs commented Feb 16, 2018

@bastienmoulia thanks for changing the target branch and sorry for the delayed response. Can you please resolve the conflicts against the new 5.x.x branch so that I can merge in? I reviewed your feedback on the SCSS mapping and I agree, that looks good!

@bastienmoulia
Copy link
Contributor Author

I generate the package-lock.json from scratch because there was to many diff.

@Stabzs Stabzs merged commit 80e6a0b into Stabzs:5.x.x/Target_Angular_5 Feb 22, 2018
@Stabzs
Copy link
Owner

Stabzs commented Feb 22, 2018

@bastienmoulia thanks again! I'll retest these changes and bump another package version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants