Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed DOB and Age from Users #89

Merged
merged 1 commit into from Jan 16, 2020
Merged

Removed DOB and Age from Users #89

merged 1 commit into from Jan 16, 2020

Conversation

rschrieken
Copy link
Contributor

@rschrieken rschrieken commented Jun 10, 2018 •
edited

Code changes:

  • Properties dropped from User model,
    • removed DOB from user merging logic
  • adapted the UserController
  • removed Age and Date of Birth from Edit and Show views to no longer render that field.

Database changes:

  • Added migration 055 to drop DOB from the Users table

This pr implements SEDE doesn't age well (aka don't let users input their Birthday on SEDE and stop showing their age) as posted on MSE.

@rschrieken
Removed DOB and Age
fef6de7 
Properties droped from User model, removed DOB from merging logic adapted the UserController and the Edit and Show views to no longer render that field. Added migration 055 to drop DOB from the Users table
@rschrieken
Copy link
Contributor Author

When investigating another issue I came across BirthDate = DemandLevel.Request in the ClaimsRequest here: https://github.com/StackExchange/StackExchange.DataExplorer/blob/master/App/StackExchange.DataExplorer/Controllers/AccountController.cs#L119

I assume that can be removed as well.

tarynpratt
tarynpratt approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@tarynpratt tarynpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@tarynpratt tarynpratt merged commit f7b6a92 into StackExchange:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarynpratt tarynpratt tarynpratt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rschrieken @tarynpratt