Allow metrics to be bound to a type early. fixes #8

StackExchange · Dec 1, 2014 · f5c38f3 · f5c38f3
1 parent 958f7f4
commit f5c38f3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 5 deletions.
diff --git a/BosunReporter/BosunReporter.cs b/BosunReporter/BosunReporter.cs
@@ -79,6 +79,24 @@ public BosunReporter(BosunReporterOptions options)
                 _metaDataTimer = new Timer(PostMetaData, null, TimeSpan.FromSeconds(30), TimeSpan.FromSeconds(options.MetaDataReportingInterval));
         }
 
+        public void BindMetric(string name, Type type)
+        {
+            name = MetricsNamePrefix + name;
+            lock (_rootNameToType)
+            {
+                if (_rootNameToType.ContainsKey(name) && _rootNameToType[name] != type)
+                {
+                    throw new Exception(
+                        String.Format("Cannot bind metric name \"{0}\" to Type {1}. It has already been bound to {2}",
+                            name, type.FullName, _rootNameToType[name].FullName));
+                }
+
+//                if (type)
+
+                _rootNameToType[name] = type;
+            }
+        }
+
         public T GetMetric<T>(string name, T metric = null) where T : BosunMetric
         {
             var metricType = typeof (T);
@@ -95,16 +113,18 @@ public BosunReporter(BosunReporterOptions options)
             name = MetricsNamePrefix + name;
             lock (_rootNameToType)
             {
-                if (_nameAndSuffixToRootName.ContainsKey(name) && (!_rootNameToType.ContainsKey(name) || _rootNameToType[name] != metricType))
+                if (_rootNameToType.ContainsKey(name))
                 {
-                    if (_rootNameToType.ContainsKey(name))
+                    if (_rootNameToType[name] != metricType)
                     {
                         throw new Exception(
                             String.Format(
-                                "Attempted to create metric name \"{0}\" with Type {1}. This metric name has already been assigned to Type {2}.",
+                                "Attempted to create metric name \"{0}\" with Type {1}. This metric name has already been bound to Type {2}.",
                                 name, metricType.FullName, _rootNameToType[name].FullName));
                     }
-
+                }
+                else if (_nameAndSuffixToRootName.ContainsKey(name))
+                {
                     throw new Exception(
                         String.Format(
                             "Attempted to create metric name \"{0}\" with Type {1}. This metric name is already in use as a suffix of Type {2}.",

diff --git a/Scratch/Program.cs b/Scratch/Program.cs
@@ -23,10 +23,12 @@ static void Main(string[] args)
                 MetricsNamePrefix = "bret.",
                 GetBosunUrl = getUrl,
                 ThrowOnPostFail = true,
-                ReportingInterval = 30,
+                ReportingInterval = 5,
                 PropertyToTagName = NameTransformers.CamelToLowerSnakeCase
             };
             var reporter = new BosunReporter.BosunReporter(options);
+
+            reporter.BindMetric("my_counter", typeof(TestCounter));
             var counter = reporter.GetMetric<TestCounter>("my_counter");
             counter.Increment();
             counter.Increment();