Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a devcontainer #1621

Merged
merged 7 commits into from May 20, 2021
Merged

Adding a devcontainer #1621

merged 7 commits into from May 20, 2021

Conversation

m0sa
Copy link
Contributor

@m0sa m0sa commented Nov 18, 2020

so that people can play around with this repo via GitHub Codespaces

image

image

image

.github/.github.csproj Outdated Show resolved Hide resolved
@m0sa
Copy link
Contributor Author

m0sa commented Nov 19, 2020

Something is up with Sentinel tests, they don't seem to be respecting the values from TestConfig.json:

image

TestConfig.Current.SentinelServer does have contain the correct value ("redis") here:

public Sentinel(ITestOutputHelper output) : base(output)
{
ConnectionLog = new StringWriter();
Skip.IfNoConfig(nameof(TestConfig.Config.SentinelServer), TestConfig.Current.SentinelServer);
Skip.IfNoConfig(nameof(TestConfig.Config.SentinelSeviceName), TestConfig.Current.SentinelSeviceName);

@m0sa
Copy link
Contributor Author

m0sa commented Nov 19, 2020

I also get omnisharp fails in github codespaces (works fine locally / wsl2 -> remote container):

image

@m0sa
Copy link
Contributor Author

m0sa commented Nov 19, 2020

woohoo, intellisense seems to light up with the 3.1 SDK installed:

image

@m0sa m0sa requested a review from mgravell February 12, 2021 12:58
@NickCraver NickCraver marked this pull request as ready for review May 20, 2021 00:56
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting v1 in, so we can play and tweak - thanks for this!!

@NickCraver NickCraver merged commit 91bfa56 into main May 20, 2021
@NickCraver NickCraver deleted the m0sa/devcontainer branch May 20, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants