Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for count argument to ListLeftPop, ListLeftPopAsync, ListRightPop, and ListRightPopAsync #1850

Merged
merged 5 commits into from Oct 5, 2021

Conversation

jjfmarket
Copy link
Contributor

Add support for count argument to ListLeftPop, ListLeftPopAsync, ListRightPop, and ListRightPopAsync

Optional Count argument was added in Redis 6.2

…RightPop, and ListRightPopAsync

Optional Count argument was added in Redis 6.2
Copy link
Collaborator

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you add something to the release notes md, too?

Also: thanks for not.falling into the trap of adding an optional arg to the existing method. You'd be surprised how often we need to explain about that.

…LeftPop, ListLeftPopAsync, ListRightPop, and ListRightPopAsync"
@jjfmarket
Copy link
Contributor Author

Added a note to the release notes 👍🏻

@NickCraver NickCraver merged commit 755a697 into StackExchange:main Oct 5, 2021
@NickCraver
Copy link
Collaborator

@jjfmarket I've been on a work break here - sorry for the slow response but your effort is very much appreciated <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants