Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support COPY #2064

Merged
merged 16 commits into from Apr 8, 2022
Merged

Support COPY #2064

merged 16 commits into from Apr 8, 2022

Conversation

Avital-Fine
Copy link
Contributor

NickCraver
NickCraver requested changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good - thanks! There are a few things I'd like to remedy inline and test a bit better but overall great. I'm happy to make the suggested changes and push if preferred soon as time allows, let me know :)

src/StackExchange.Redis/Interfaces/IDatabase.cs Outdated Show resolved Hide resolved
src/StackExchange.Redis/Interfaces/IDatabaseAsync.cs Outdated Show resolved Hide resolved
src/StackExchange.Redis/RedisDatabase.cs Outdated Show resolved Hide resolved
tests/StackExchange.Redis.Tests/BasicOps.cs Outdated Show resolved Hide resolved
mgravell
mgravell previously requested changes Apr 4, 2022
View reviewed changes
tests/StackExchange.Redis.Tests/BasicOps.cs Outdated Show resolved Hide resolved
NickCraver
NickCraver reviewed Apr 4, 2022
View reviewed changes
docs/ReleaseNotes.md Outdated Show resolved Hide resolved
Avital-Fine and others added 3 commits April 4, 2022 18:34
@Avital-Fine
Update ReleaseNotes.md
9e82a90
@NickCraver
Merge branch 'main' into pr/2064
9316527
@NickCraver
Skip cop on incapable test servers!
83b083c 
Also adds a new version-based skip override so we can more simply apply this in ongoing PRs.
@NickCraver NickCraver self-requested a review April 8, 2022 01:29
NickCraver
NickCraver approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current is looking great - thanks for this!

@NickCraver NickCraver merged commit 58cbef0 into StackExchange:main Apr 8, 2022
@NickCraver NickCraver mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

@mgravell mgravell Awaiting requested review from mgravell

Assignees
No one assigned
Labels
⚙️ area:API ⚙️ area:commands ➕ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Avital-Fine @mgravell @NickCraver