Implement high integrity mode for commands #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
changed the title
NickCraver
reviewed
Jun 18, 2024
src/StackExchange.Redis/Configuration/DefaultOptionsProvider.cs
Outdated
Show resolved
Hide resolved
src/StackExchange.Redis/Configuration/DefaultOptionsProvider.cs
Outdated
Show resolved
Hide resolved
NickCraver
changed the title
- add transaction work to basic tests, to ensure handled
- burn the connection on failure - add initial metrics
philon-msft
approved these changes
Jun 24, 2024
| @@ -6,7 +6,7 @@ | |||
| <AssemblyName>BasicTest</AssemblyName> | |||
| <OutputType>Exe</OutputType> | |||
| <PackageId>BasicTest</PackageId> | |||
| <RuntimeIdentifiers>win7-x64</RuntimeIdentifiers> | |||
| <!--<RuntimeIdentifiers>win7-x64</RuntimeIdentifiers>--> | |||
| @@ -6,7 +6,7 @@ | |||
| <AssemblyName>BasicTestBaseline</AssemblyName> | |||
| <OutputType>Exe</OutputType> | |||
| <PackageId>BasicTestBaseline</PackageId> | |||
| <RuntimeIdentifiers>win7-x64</RuntimeIdentifiers> | |||
| <!--<RuntimeIdentifiers>win7-x64</RuntimeIdentifiers>--> | |||
There was a problem hiding this comment.
it isn't the core - I'm fine with leaving it for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2706
This adds additional
ECHOitems after every outbound request, and adds validation of that correlation marker before treating responses as valid.This is initial draft only; needs conversion to sequence and testing of failure modes.
Discussion points