fix: fix table serialization having incorrect trailing whitespace

StackExchange · Apr 12, 2022 · 5a4c9b0 · 5a4c9b0
1 parent 82cb165
commit 5a4c9b0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/rich-text/markdown-serializer.ts b/src/rich-text/markdown-serializer.ts
@@ -343,6 +343,7 @@ const customMarkdownSerializerNodes: MarkdownSerializerNodes = {
                     columnAlignments = serializeTableRow(headRow);
                 }
             });
+            state.ensureNewLine();
 
             // write table header separator
             for (const alignment of columnAlignments) {
@@ -357,7 +358,6 @@ const customMarkdownSerializerNodes: MarkdownSerializerNodes = {
                 );
             }
             state.write("|");
-            state.ensureNewLine();
         }
 
         function serializeTableBody(body: ProsemirrorNode) {
@@ -366,11 +366,11 @@ const customMarkdownSerializerNodes: MarkdownSerializerNodes = {
                     serializeTableRow(bodyRow);
                 }
             });
-            state.ensureNewLine();
         }
 
         function serializeTableRow(row: ProsemirrorNode): string[] {
             const columnAlignment: string[] = [];
+            state.ensureNewLine();
             row.forEach((cell) => {
                 if (
                     cell.type === richTextSchema.nodes.table_header ||
@@ -381,7 +381,6 @@ const customMarkdownSerializerNodes: MarkdownSerializerNodes = {
                 }
             });
             state.write("|");
-            state.ensureNewLine();
             return columnAlignment;
         }
 
@@ -416,8 +415,7 @@ const customMarkdownSerializerNodes: MarkdownSerializerNodes = {
                 serializeTableBody(table_child);
         });
 
-        state.ensureNewLine();
-        state.write("\n");
+        state.closeBlock(node);
     },
 
     tagLink(state, node) {

diff --git a/test/rich-text/markdown-serializer.test.ts b/test/rich-text/markdown-serializer.test.ts
@@ -87,6 +87,7 @@ describe("markdown-serializer", () => {
     /**
      * Represents different types of data that were rendered differently in markup.
      * All entries should render exactly the same before and after rich-text conversion.
+     * NOTE: some serialization tests are in the tests for the plugin that implemented the feature (e.g. html)
      */
     const markupSerializeData = [
         /* Nodes */
@@ -100,7 +101,7 @@ describe("markdown-serializer", () => {
         "~~~\ntest\n~~~",
         `<pre><code>test</code></pre>`,
         `# ATX heading`,
-        //`Setext heading\n===`,
+        //`Setext heading\n===`, // TODO
         `<h1>html heading</h1>`,
         `<h2>html heading</h2>`,
         `<h3>html heading</h3>`,
@@ -150,8 +151,9 @@ describe("markdown-serializer", () => {
         `test<br>test`,
         `test<br/>test`,
         `test<br />test`,
-        // TODO html_inline, html_block, html_block_container
-        // TODO stack_snippet, table, taglink, spoiler
+        /* Tables */
+        `| foo | bar |\n| --- | --- |\n| baz | bim |`,
+        `| abc | def | ghi |\n|:---:|:--- | ---:|\n| foo | bar | baz |`,
         /* Marks */
         `*test*`,
         `_test_`,