fix: toggle heading only when same level

Fixes #105
StackExchange · May 11, 2022 · 9491176 · 9491176
1 parent e709127
commit 9491176
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/rich-text/commands/index.ts b/src/rich-text/commands/index.ts
@@ -73,11 +73,11 @@ function toggleWrapIn(nodeType: NodeType) {
 /** Command to set a block type to a paragraph (plain text) */
 const setToTextCommand = setBlockType(schema.nodes.paragraph);
 
-function toggleBlockType(
+export function toggleBlockType(
     nodeType: NodeType,
     attrs?: { [key: string]: unknown }
 ) {
-    const nodeCheck = nodeTypeActive(nodeType);
+    const nodeCheck = nodeTypeActive(nodeType, attrs);
     const setBlockTypeCommand = setBlockType(nodeType, attrs);
 
     return (state: EditorState, dispatch: (tr: Transaction) => void) => {

diff --git a/test/rich-text/commands/index.test.ts b/test/rich-text/commands/index.test.ts
@@ -41,6 +41,8 @@ describe("commands", () => {
     describe("toggleBlockType", () => {
         it.todo("should insert a paragraph at the end of the doc");
         it.todo("should not insert a paragraph at the end of the doc");
+        it.todo("should change heading level from 1 to 2");
+        it.todo("should change toggle heading off");
     });
 
     describe("insertHorizontalRuleCommand", () => {