fix: fix table menu entry always manipulating the menu icon of the la…

…st initialized editor instance
StackExchange · Feb 25, 2022 · cc592c1 · cc592c1
1 parent b69c3e0
commit cc592c1
Showing 1 changed file with 32 additions and 31 deletions.
diff --git a/src/rich-text/commands/index.ts b/src/rich-text/commands/index.ts
@@ -181,38 +181,39 @@ function markActive(mark: MarkType) {
     };
 }
 
-const tableDropdown = makeMenuDropdown(
-    "Table",
-    "Edit table",
-    "table-dropdown",
-    (state: EditorState) => inTable(state.selection),
+const tableDropdown = () =>
+    makeMenuDropdown(
+        "Table",
+        "Edit table",
+        "table-dropdown",
+        (state: EditorState) => inTable(state.selection),
 
-    dropdownSection("Column", "columnSection"),
-    dropdownItem("Remove column", removeColumnCommand, "remove-column-btn"),
-    dropdownItem(
-        "Insert column before",
-        insertTableColumnBeforeCommand,
-        "insert-column-before-btn"
-    ),
-    dropdownItem(
-        "Insert column after",
-        insertTableColumnAfterCommand,
-        "insert-column-after-btn"
-    ),
+        dropdownSection("Column", "columnSection"),
+        dropdownItem("Remove column", removeColumnCommand, "remove-column-btn"),
+        dropdownItem(
+            "Insert column before",
+            insertTableColumnBeforeCommand,
+            "insert-column-before-btn"
+        ),
+        dropdownItem(
+            "Insert column after",
+            insertTableColumnAfterCommand,
+            "insert-column-after-btn"
+        ),
 
-    dropdownSection("Row", "rowSection"),
-    dropdownItem("Remove row", removeRowCommand, "remove-row-btn"),
-    dropdownItem(
-        "Insert row before",
-        insertTableRowBeforeCommand,
-        "insert-row-before-btn"
-    ),
-    dropdownItem(
-        "Insert row after",
-        insertTableRowAfterCommand,
-        "insert-row-after-btn"
-    )
-);
+        dropdownSection("Row", "rowSection"),
+        dropdownItem("Remove row", removeRowCommand, "remove-row-btn"),
+        dropdownItem(
+            "Insert row before",
+            insertTableRowBeforeCommand,
+            "insert-row-before-btn"
+        ),
+        dropdownItem(
+            "Insert row after",
+            insertTableRowAfterCommand,
+            "insert-row-after-btn"
+        )
+    );
 
 export const createMenu = (options: CommonViewOptions): Plugin =>
     createMenuPlugin(
@@ -289,7 +290,7 @@ export const createMenu = (options: CommonViewOptions): Plugin =>
                 },
                 options.parserFeatures.tables
             ),
-            addIf(tableDropdown, options.parserFeatures.tables),
+            addIf(tableDropdown(), options.parserFeatures.tables),
             makeMenuSpacerEntry(),
             {
                 key: "toggleOrderedList",